You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/28 12:14:36 UTC
[GitHub] clintropolis commented on a change in pull request #7154: rename
maintenance mode to decommission
clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission
URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r261168138
##########
File path: docs/content/configuration/index.md
##########
@@ -783,8 +783,8 @@ A sample Coordinator dynamic config JSON object is shown below:
"replicationThrottleLimit": 10,
"emitBalancingStats": false,
"killDataSourceWhitelist": ["wikipedia", "testDatasource"],
- "historicalNodesInMaintenance": ["localhost:8182", "localhost:8282"],
- "nodesInMaintenancePriority": 7
+ "decommissionNodes": ["localhost:8182", "localhost:8282"],
+ "decommissionPriority": 7
Review comment:
Makes sense to me, though I think the properties should be consistent named so maybe I'll either rename the other `decommissioningNodes` or call this one `decommissionVelocity` to match. Anyone have a preference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org