You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ssabhijith2000 (via GitHub)" <gi...@apache.org> on 2024/09/02 09:54:20 UTC
[I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
ssabhijith2000 opened a new issue, #30124:
URL: https://github.com/apache/superset/issues/30124
### Bug description
We get a forbidden toaster when users without link share permission click on the link icon. Even though this is an expected behavior, a link icon is unnecessary if it does not work. This is creating confusions
### How to reproduce the bug
1. Take away link share permission from the user
2. Go to any dashboard
3. Create a new tab in the dashboard.
4. Click on share link Icon
### Screenshots/recordings
https://github.com/user-attachments/assets/e445f178-6a24-418f-9b61-22b7eb83a06f
### Superset version
3.1.3
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #30124:
URL: https://github.com/apache/superset/issues/30124#issuecomment-2324320827
<!-- Greeting -->
Hello, @ssabhijith2000! I'm here to help you with any bugs, questions, or contributions you have for the repository. Let me know how I can assist you!
<!-- Answer -->
To address the issue of the forbidden toaster error when a user without link share permission clicks on the link icon in Superset version 3.1.3, you can add a permission check before attempting to generate the permalink. If the user does not have the required permission, you can show an appropriate message or disable the link icon.
Here is an example of how you can modify the `ShareMenuItems` component to include a permission check:
```tsx
import React, { useEffect, useState } from 'react';
import { Menu } from 'src/components/Menu';
import { useSelector } from 'react-redux';
import { SupersetClient } from '@superset-ui/core';
import { t } from '@superset-ui/core';
import PropTypes from 'prop-types';
const ShareMenuItems = ({
addDangerToast,
addSuccessToast,
url,
copyMenuItemTitle,
emailMenuItemTitle,
emailSubject,
emailBody,
dashboardId,
}) => {
const [hasPermission, setHasPermission] = useState(false);
useEffect(() => {
// Fetch user permissions
SupersetClient.get({
endpoint: `/api/v1/dashboard/${dashboardId}/permissions`,
})
.then(({ json }) => {
if (json.permissions.includes('can_share_dashboard')) {
setHasPermission(true);
}
})
.catch(() => {
addDangerToast(t('Sorry, something went wrong. Try again later.'));
});
}, [dashboardId, addDangerToast]);
const handleCopyLink = async () => {
if (!hasPermission) {
addDangerToast(t('You do not have permission to share this dashboard.'));
return;
}
try {
const response = await SupersetClient.post({
endpoint: `/api/v1/dashboard/${dashboardId}/permalink`,
});
const { url } = await response.json();
await copyTextToClipboard(url);
addSuccessToast(t('Copied to clipboard!'));
} catch (error) {
addDangerToast(t('Sorry, something went wrong. Try again later.'));
}
};
return (
<Menu onClick={jest.fn()} selectable={false} data-test="main-menu">
<Menu.Item key="copy-link" onClick={handleCopyLink}>
{copyMenuItemTitle}
</Menu.Item>
<Menu.Item key="share-email">
<a
href={`mailto:?Subject=${emailSubject}&Body=${emailBody}${url}`}
target="_blank"
rel="noopener noreferrer"
>
{emailMenuItemTitle}
</a>
</Menu.Item>
</Menu>
);
};
ShareMenuItems.propTypes = {
addDangerToast: PropTypes.func.isRequired,
addSuccessToast: PropTypes.func.isRequired,
url: PropTypes.string.isRequired,
copyMenuItemTitle: PropTypes.string.isRequired,
emailMenuItemTitle: PropTypes.string.isRequired,
emailSubject: PropTypes.string.isRequired,
emailBody: PropTypes.string.isRequired,
dashboardId: PropTypes.string.isRequired,
};
export default ShareMenuItems;
```
Additionally, you can refer to the `URLShortLinkButton` component in the Superset codebase for a similar implementation. This component includes a mechanism to handle the sharing of dashboard links:
```tsx
import { useState } from 'react';
import { getClientErrorObject, t } from '@superset-ui/core';
import Popover, { PopoverProps } from 'src/components/Popover';
import CopyToClipboard from 'src/components/CopyToClipboard';
import { getDashboardPermalink } from 'src/utils/urlUtils';
import { useToasts } from 'src/components/MessageToasts/withToasts';
import { useSelector } from 'react-redux';
import { RootState } from 'src/dashboard/types';
export type URLShortLinkButtonProps = {
dashboardId: number;
anchorLinkId?: string;
emailSubject?: string;
emailContent?: string;
placement?: PopoverProps['placement'];
};
export default function URLShortLinkButton({
dashboardId,
anchorLinkId,
placement = 'right',
emailContent = '',
emailSubject = '',
}: URLShortLinkButtonProps) {
const [shortUrl, setShortUrl] = useState('');
const { addDangerToast } = useToasts();
const { dataMask, activeTabs } = useSelector((state: RootState) => ({
dataMask: state.dataMask,
activeTabs: state.dashboardState.activeTabs,
}));
const getCopyUrl = async () => {
try {
const url = await getDashboardPermalink({
dashboardId,
dataMask,
activeTabs,
anchor: anchorLinkId,
});
setShortUrl(url);
} catch (error) {
if (error) {
addDangerToast(
(await getClientErrorObject(error)).error ||
t('Something went wrong.'),
);
}
}
};
const emailBody = `${emailContent}${shortUrl || ''}`;
const emailLink = `mailto:?Subject=${emailSubject}%20&Body=${emailBody}`;
return (
<Popover
trigger="click"
placement={placement}
content={
<div
id="shorturl-popover"
data-test="shorturl-popover"
onClick={e => {
e.stopPropagation();
}}
>
<CopyToClipboard
text={shortUrl}
copyNode={
<i className="fa fa-clipboard" title={t('Copy to clipboard')} />
}
/>
<a href={emailLink}>
<i className="fa fa-envelope" />
</a>
</div>
}
>
<span
className="short-link-trigger btn btn-default btn-sm"
tabIndex={-1}
role="button"
onClick={e => {
e.stopPropagation();
getCopyUrl();
}}
>
<i className="short-link-trigger fa fa-link" />
</span>
</Popover>
);
}
```
In this example, the `getCopyUrl` function handles the URL generation and error handling. This approach ensures that users without the necessary permissions are informed appropriately and prevents the forbidden toaster error <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx)</sup><sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx)</sup><sup>[[3]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/URLShortLinkButton/index.tsx)</sup><sup>[[4]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx)</sup>.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30124:
URL: https://github.com/apache/superset/issues/30124#issuecomment-3109651805
We're still open to a PR here, if anyone is interested, but otherwise we might consider this 'not planned' or move it to a Discussion of the "Ideas" variety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30124:
URL: https://github.com/apache/superset/issues/30124#issuecomment-4035390042
As @rusackas noted, this might be considered 'not planned' or converted to an 'Ideas' discussion. The current behavior (showing a 'forbidden' toast when a user without link-share permission clicks the icon) could be improved by hiding the icon from users who lack permission. PRs welcome, otherwise this may be closed as not planned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30124:
URL: https://github.com/apache/superset/issues/30124#issuecomment-4898552253
Closing this since there are no takers, but happy to move it to a discussion if anyone wants to tackle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30124:
URL: https://github.com/apache/superset/issues/30124#issuecomment-2332086080
It looks like Dosu is on the right path here... would you be willing to open a PR that renders the link conditionally based on permission rather than letting the user try/fail upon click?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #30124: Getting forbidden toaster when a user without link share permission clicks on the link icon
URL: https://github.com/apache/superset/issues/30124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Getting forbidden toaster when a user without link share permission clicks on the link icon [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30124:
URL: https://github.com/apache/superset/issues/30124#issuecomment-2791185499
This probably could/should be addressed in a similar fashion to https://github.com/apache/superset/pull/32995 (on which we're still aligning on the implementation plan, so let's merge that first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org