[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1070: LUCENE-9089: FST Builder fluent-style constructor.

[GitBox <gi...@apache.org>]

juanka588 commented on a change in pull request #1070: LUCENE-9089: FST Builder fluent-style constructor.
URL: https://github.com/apache/lucene-solr/pull/1070#discussion_r356707446
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/util/fst/Builder.java
 ##########
 @@ -205,22 +156,145 @@ public Builder(FST.INPUT_TYPE inputType, int minSuffixCount1, int minSuffixCount
   }
 
   /**
-   * Overrides the default the maximum oversizing of fixed array allowed to enable direct addressing
-   * of arcs instead of binary search.
+   * Fluent-style constructor for FST {@link Builder}.
    * <p>
-   * Setting this factor to a negative value (e.g. -1) effectively disables direct addressing,
-   * only binary search nodes will be created.
-   *
-   * @see #DIRECT_ADDRESSING_MAX_OVERSIZING_FACTOR
+   * Creates an FST/FSA builder with all the possible tuning and construction tweaks.
+   * Read parameter documentation carefully.
    */
-  public Builder<T> setDirectAddressingMaxOversizingFactor(float factor) {
-    directAddressingMaxOversizingFactor = factor;
-    return this;
+  public static class Constructor<T> {
 
 Review comment:
   re name to builder

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org