You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2020/03/13 15:34:25 UTC
[kudu] 03/03: [gradle] remove failOnNoMatchingTests
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 84745c30253aee48da4f4a05da1fb187281bf0e6
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Fri Mar 13 00:03:34 2020 -0700
[gradle] remove failOnNoMatchingTests
I found it confusing when gradle reports success on executing test
targets which don't exist. Prior to this patch, the following returned
success and claimed successfully executing tasks:
$ ./gradlew :kudu-client:test --tests org.apache.kudu.client.Nonsense
BUILD SUCCESSFUL in 1s
15 actionable tasks: 1 executed, 14 up-to-date
This patch fixes it by removing failOnNoMatchingTests.
It seems there were some ramifications on the pattern matching for
dist-test some time ago, but I verified prior and after this patch
and saw that the following works and breaks the same way:
works:
../build-support/dist_test.py java loop -n 8 '*ITClient'
../build-support/dist_test.py java loop -n 8 '*ITClient*'
../build-support/dist_test.py java loop -n 8 org/apache/kudu/client/TestConnectToCluster
doesn't work:
../build-support/dist_test.py java loop -n 8 '*ITClient.class'
../build-support/dist_test.py java loop -n 8 '*ITClient*X'
../build-support/dist_test.py java loop -n 8 org/apache/kudu/client/TestConnectToCluster.class
Change-Id: Iabb0f72fb9481c775ebcc9881a39180fb0413154
Reviewed-on: http://gerrit.cloudera.org:8080/15428
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
java/gradle/tests.gradle | 7 -------
1 file changed, 7 deletions(-)
diff --git a/java/gradle/tests.gradle b/java/gradle/tests.gradle
index eaf083b..51a3d7f 100644
--- a/java/gradle/tests.gradle
+++ b/java/gradle/tests.gradle
@@ -80,13 +80,6 @@ tasks.withType(Test) {
systemProperty "testRandomSeed", propertyWithDefault("testRandomSeed", null)
}
- // Don't fail the build if a --tests filter doesn't match any tests.
- // This is useful for filtering tests from the top of the project where some
- // subprojects won't match the filter. Without this, those subprojects would fail.
- filter {
- failOnNoMatchingTests = false
- }
-
// Force the tests to be rerun if the rerunTests property is set.
if (propertyExists("rerunTests")) {
outputs.upToDateWhen { false }