You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/19 00:49:33 UTC

[GitHub] [hudi] vinothchandar commented on a change in pull request #4417: [HUDI-3094] Unify Hive's InputFormat implementations to avoid duplication

vinothchandar commented on a change in pull request #4417:
URL: https://github.com/apache/hudi/pull/4417#discussion_r787260937



##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java
##########
@@ -63,102 +54,22 @@
  */
 @UseRecordReaderFromInputFormat
 @UseFileSplitsFromInputFormat
-public class HoodieParquetInputFormat extends MapredParquetInputFormat implements Configurable {
+public class HoodieParquetInputFormat extends HoodieFileInputFormatBase implements Configurable {

Review comment:
       this is a problem. Hive code special cases subclasses of  `MapredParquetInputFormat` for some of the optimizations. So we need to maintain this hierarchy.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org