You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/24 09:22:26 UTC
[GitHub] [netbeans] fcorneli opened a new pull request #2560: improved help on JSF composite component attributes
fcorneli opened a new pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560
This PR improves the help on JSF (composite) component attributes.
Also visualizes the type of the attribute, which is what I was always missing during development.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560#discussion_r531208736
##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/facelets/CompositeComponentLibrary.java
##########
@@ -250,9 +250,11 @@ private synchronized void load() {
for (Map<String, String> attrsMap : model.getExistingInterfaceAttributes()) {
String attrname = attrsMap.get("name"); //NOI18N
boolean required = Boolean.parseBoolean(attrsMap.get("required")); //NOI18N
- String attributeDescription = getAttributesDescription(model, true);
+ String attributeDescription = attrsMap.get("shortDescription"); //NOI18N
Review comment:
Could you please describe what this change means? A visualization would be helpful.
##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/completion/JsfCompletionItem.java
##########
@@ -260,6 +260,11 @@ private String getHelpContent() {
sb.append("<h1>"); //NOI18N
sb.append(attr.getName());
sb.append("</h1>"); //NOI18N
+ if (attr.getType() != null) {
+ sb.append("<div><b>Type:</b> "); //NOI18N
Review comment:
The NOI18N is not totally correct here. it is valid for the html tags, but not the text itself. Please move the text "Type" to "Bundle.properties". See "MSG_RequiredAttribute" and "MSG_NoAttributeDescription" below.
I just realised, that in line 257 the same issue is already present. It would be great, if you could also fix 257.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] fcorneli commented on a change in pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes
Posted by GitBox <gi...@apache.org>.
fcorneli commented on a change in pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560#discussion_r531224740
##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/completion/JsfCompletionItem.java
##########
@@ -260,6 +260,11 @@ private String getHelpContent() {
sb.append("<h1>"); //NOI18N
sb.append(attr.getName());
sb.append("</h1>"); //NOI18N
+ if (attr.getType() != null) {
+ sb.append("<div><b>Type:</b> "); //NOI18N
Review comment:
I'll have a look at the i18n handling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] fcorneli commented on a change in pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes
Posted by GitBox <gi...@apache.org>.
fcorneli commented on a change in pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560#discussion_r531218214
##########
File path: enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/facelets/CompositeComponentLibrary.java
##########
@@ -250,9 +250,11 @@ private synchronized void load() {
for (Map<String, String> attrsMap : model.getExistingInterfaceAttributes()) {
String attrname = attrsMap.get("name"); //NOI18N
boolean required = Boolean.parseBoolean(attrsMap.get("required")); //NOI18N
- String attributeDescription = getAttributesDescription(model, true);
+ String attributeDescription = attrsMap.get("shortDescription"); //NOI18N
Review comment:
With `getAttributesDescription` you used to get the description of all attributes on each individual attribute, without any distinction. Hence the full list all over the place. By using `shortDescription`, you really get just the description of the corresponding attribute, which is what you actually want to see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2560: [NETBEANS-5057] improved help on JSF composite component attributes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2560:
URL: https://github.com/apache/netbeans/pull/2560#issuecomment-738988410
Merged via https://github.com/apache/netbeans/commit/fcdaae816f9cd7bfc8fed39f605165d553a6c165. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists