You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/23 11:49:49 UTC
[GitHub] [flink] yuruguo opened a new pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
yuruguo opened a new pull request #14477:
URL: https://github.com/apache/flink/pull/14477
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request allow users to overwrite hadoop (keys in [core-default.xml](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml) and [hdfs-default.xml](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml)) / yarn (keys in [yarn-default.xml](https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-common/yarn-default.xml)) configuration by corresponding set flink configuration started with prefix "flink.hadoop." / "flink.yarn.". It is convenient for users to set hadoop / yarn configuration, because they can only focus on flink configuration.
## Brief change log
- *Add all configuration key with prefix `flink.hadoop.` in flink conf to hadoop conf*
- *Add all configuration key with prefix `flink.yarn.` in flink conf to yarn conf*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: ( no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r555623971
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -334,18 +334,32 @@
.stringType()
.noDefaultValue()
.withDescription(
- "A general option to probe Hadoop configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from <a href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml\">core-default.xml</a> "
- + "and <a href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml\">hdfs-default.xml</a>) then set the <key> and value to Hadoop configuration. "
- + "For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.");
+ Description.builder()
+ .text(
+ "A general option to probe Hadoop configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from %s and %s) then set the <key> and value to Hadoop configuration."
+ + " For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.",
+ link(
+ "https://hadoop.apache.org/docs/r2.4.1/hadoop-project-dist/hadoop-common/core-default.xml",
Review comment:
Why did you change the link to Hadoop version 2.4.1 from stable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r555664377
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -334,18 +334,32 @@
.stringType()
.noDefaultValue()
.withDescription(
- "A general option to probe Hadoop configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from <a href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml\">core-default.xml</a> "
- + "and <a href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml\">hdfs-default.xml</a>) then set the <key> and value to Hadoop configuration. "
- + "For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.");
+ Description.builder()
+ .text(
+ "A general option to probe Hadoop configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from %s and %s) then set the <key> and value to Hadoop configuration."
+ + " For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.",
+ link(
+ "https://hadoop.apache.org/docs/r2.4.1/hadoop-project-dist/hadoop-common/core-default.xml",
Review comment:
Thanks for your review again @tillrohrmann.
Because I found that configuration option `yarn.application-attempts` is based on v2.4.1, so I continue to use 2.4.1 for alignment. If unbundling with a specific version is a better way, then I will use the most recent stable version instead, including `yarn.application-attempts`.
If it's ok, I will update again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa9776ffae2b203d7c6980f4f7a32b70c26c6477 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708)
* 1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
}, {
"hash" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce120460bdf7625d4a588d546a6a8abe3a125273 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891)
* 6bd626ab6587a08718ae6c04a695074471c158f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 472c9d41864d5c6834f0932a4a1cefca9a5e262d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553311795
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -77,6 +78,8 @@ public ApplicationId getClusterId(Configuration configuration) {
private YarnClusterDescriptor getClusterDescriptor(Configuration configuration) {
final YarnClient yarnClient = YarnClient.createYarnClient();
final YarnConfiguration yarnConfiguration = new YarnConfiguration();
+ yarnConfiguration.addResource(HadoopUtils.getHadoopConfiguration(configuration));
+ yarnConfiguration.addResource(Utils.getYarnConfiguration(configuration));
Review comment:
Yes, it is better to put it into the `Utils` class of `flink-yarn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712)
* 818aae8eb16f682e089d8616e03b2873ca8ea64e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
}, {
"hash" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924",
"triggerID" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"triggerType" : "PUSH"
}, {
"hash" : "e94718c010b40322a4968d9e6130e90c5f6fd5e4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e94718c010b40322a4968d9e6130e90c5f6fd5e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce120460bdf7625d4a588d546a6a8abe3a125273 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891)
* 6bd626ab6587a08718ae6c04a695074471c158f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924)
* e94718c010b40322a4968d9e6130e90c5f6fd5e4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553957897
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
I think we should still put this logic in the `Utils` class and then reuse it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553254765
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -77,6 +78,8 @@ public ApplicationId getClusterId(Configuration configuration) {
private YarnClusterDescriptor getClusterDescriptor(Configuration configuration) {
final YarnClient yarnClient = YarnClient.createYarnClient();
final YarnConfiguration yarnConfiguration = new YarnConfiguration();
+ yarnConfiguration.addResource(HadoopUtils.getHadoopConfiguration(configuration));
+ yarnConfiguration.addResource(Utils.getYarnConfiguration(configuration));
Review comment:
If `HadoopUtils` provides both `getHadoopConfiguration` and `getYarnConfiguration`, then it could be consistent and simplify code https://github.com/apache/flink/pull/14477#discussion_r553198430.
But I am not sure if it is really appropriate and standardized to put `getYarnConfiguration` in the `flink-hadoop-fs` module, because the `flink-yarn` module itself has `Utils`, it may be more clear to use it directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 472c9d41864d5c6834f0932a4a1cefca9a5e262d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248)
* 90ad920f7f511a6f66ffbc50f371343dad4f55b1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712)
* 818aae8eb16f682e089d8616e03b2873ca8ea64e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553858002
##########
File path: docs/_includes/generated/yarn_config_configuration.html
##########
@@ -14,6 +14,20 @@
<td>String</td>
<td>If configured, Flink will add this key to the resource profile of container request to Yarn. The value will be set to the value of external-resource.<resource_name>.amount.</td>
</tr>
+ <tr>
+ <td><h5>flink.hadoop.<hadoop_key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Hadoop configuration through prefix `flink.hadoop.`. Flink will remove the prefix to get hadoop_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml">core-default.xml</a> and <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml">hdfs-default.xml</a>) then set the hadoop_key and value to Hadoop configuration. For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>flink.yarn.<key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Yarn configuration through prefix `flink.yarn.`. Flink will remove the prefix `flink.` to get yarn_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-common/yarn-default.xml">yarn-default.xml</a>) then set the yarn_key and value to Yarn configuration. For example, flink.yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Flink configuration and convert to yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Yarn configuration.
+ </td>
+ </tr>
Review comment:
@tillrohrmann I have added two options `flink.yarn.<key>` and `flink.hadoop.<key>` in `YarnConfigOptions` and auto generated related description in HTML document.
Then please take a look at this modification and evaluate the completion of this pr, thx!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750212036
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e94718c010b40322a4968d9e6130e90c5f6fd5e4 (Fri May 28 07:06:33 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553255576
##########
File path: docs/_includes/generated/yarn_config_configuration.html
##########
@@ -14,6 +14,20 @@
<td>String</td>
<td>If configured, Flink will add this key to the resource profile of container request to Yarn. The value will be set to the value of external-resource.<resource_name>.amount.</td>
</tr>
+ <tr>
+ <td><h5>flink.hadoop.<hadoop_key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Hadoop configuration through prefix `flink.hadoop.`. Flink will remove the prefix to get hadoop_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml">core-default.xml</a> and <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml">hdfs-default.xml</a>) then set the hadoop_key and value to Hadoop configuration. For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>flink.yarn.<key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Yarn configuration through prefix `flink.yarn.`. Flink will remove the prefix `flink.` to get yarn_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-common/yarn-default.xml">yarn-default.xml</a>) then set the yarn_key and value to Yarn configuration. For example, flink.yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Flink configuration and convert to yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Yarn configuration.
+ </td>
+ </tr>
Review comment:
Thanks for your guidance, I understand its generation mechanism and I will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r554300858
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
Ok @tillrohrmann, We can slightly modify the `getYarnConfiguration` method in the `Utils` class to call `HadoopUtils.getHadoopConfiguration(flinkConfig)`, as follows:
then `getYarnConfiguration` can be reused everywhere needed,as follows:
in `YarnClusterClientFactory` class
in `YarnResourceManagerDriver` class
Or another way is to keep the `getYarnConfiguration` method unchanged and add a new method `loadYarnConfiguration` in the `Utils` class, as follows：
then `loadYarnConfiguration` can be reused everywhere needed.
Which one do you think is appropriate? THX!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 818aae8eb16f682e089d8616e03b2873ca8ea64e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741)
* ce120460bdf7625d4a588d546a6a8abe3a125273 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
}, {
"hash" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924",
"triggerID" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"triggerType" : "PUSH"
}, {
"hash" : "e94718c010b40322a4968d9e6130e90c5f6fd5e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11939",
"triggerID" : "e94718c010b40322a4968d9e6130e90c5f6fd5e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6bd626ab6587a08718ae6c04a695074471c158f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924)
* e94718c010b40322a4968d9e6130e90c5f6fd5e4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11939)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553245985
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -77,6 +78,8 @@ public ApplicationId getClusterId(Configuration configuration) {
private YarnClusterDescriptor getClusterDescriptor(Configuration configuration) {
final YarnClient yarnClient = YarnClient.createYarnClient();
final YarnConfiguration yarnConfiguration = new YarnConfiguration();
+ yarnConfiguration.addResource(HadoopUtils.getHadoopConfiguration(configuration));
Review comment:
I find this `yarnConfiguration` can be used to get FileSystem in YarnClusterDescriptor.class, such as in`startAppMaster` method:
So add `HadoopConfiguration` to benefit the filesystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90ad920f7f511a6f66ffbc50f371343dad4f55b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa9776ffae2b203d7c6980f4f7a32b70c26c6477 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce120460bdf7625d4a588d546a6a8abe3a125273 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553198430
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java
##########
@@ -114,6 +117,24 @@ public static Configuration getHadoopConfiguration(
addHadoopConfIfFound(result, hadoopConfDir) || foundHadoopConfiguration;
}
+ // Approach 4: Flink configuration
+ // add all configuration key with prefix `flink.hadoop.` in flink conf to hadoop conf
+ for (String key : flinkConfiguration.keySet()) {
+ for (String prefix : FLINK_CONFIG_PREFIXES) {
+ if (key.startsWith(prefix)) {
+ String newKey = key.substring(prefix.length());
+ String value = flinkConfiguration.getString(key, null);
+ result.set(newKey, value);
+ LOG.debug(
+ "Adding Flink config entry for {} as {}={} to Hadoop config",
+ key,
+ newKey,
+ value);
+ foundHadoopConfiguration = true;
+ }
+ }
+ }
Review comment:
This code block and the one for the Yarn configuration look pretty much the same. Maybe we can deduplicate them.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -77,6 +78,8 @@ public ApplicationId getClusterId(Configuration configuration) {
private YarnClusterDescriptor getClusterDescriptor(Configuration configuration) {
final YarnClient yarnClient = YarnClient.createYarnClient();
final YarnConfiguration yarnConfiguration = new YarnConfiguration();
+ yarnConfiguration.addResource(HadoopUtils.getHadoopConfiguration(configuration));
Review comment:
Why is it necessary to add the `HadoopConfiguration` here?
##########
File path: docs/_includes/generated/yarn_config_configuration.html
##########
@@ -14,6 +14,20 @@
<td>String</td>
<td>If configured, Flink will add this key to the resource profile of container request to Yarn. The value will be set to the value of external-resource.<resource_name>.amount.</td>
</tr>
+ <tr>
+ <td><h5>flink.hadoop.<hadoop_key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Hadoop configuration through prefix `flink.hadoop.`. Flink will remove the prefix to get hadoop_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml">core-default.xml</a> and <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml">hdfs-default.xml</a>) then set the hadoop_key and value to Hadoop configuration. For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>flink.yarn.<key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Yarn configuration through prefix `flink.yarn.`. Flink will remove the prefix `flink.` to get yarn_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-common/yarn-default.xml">yarn-default.xml</a>) then set the yarn_key and value to Yarn configuration. For example, flink.yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Flink configuration and convert to yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Yarn configuration.
+ </td>
+ </tr>
Review comment:
This file is generated. I think we can add a `ConfigOption` with the key `flink.yarn.<key>` and `flink.hadoop.<key>` and the corresponding descriptions to `YarnConfigOptions`.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -77,6 +78,8 @@ public ApplicationId getClusterId(Configuration configuration) {
private YarnClusterDescriptor getClusterDescriptor(Configuration configuration) {
final YarnClient yarnClient = YarnClient.createYarnClient();
final YarnConfiguration yarnConfiguration = new YarnConfiguration();
+ yarnConfiguration.addResource(HadoopUtils.getHadoopConfiguration(configuration));
+ yarnConfiguration.addResource(Utils.getYarnConfiguration(configuration));
Review comment:
Would it make sense to load the `YarnConfiguration` through a utility. Maybe even `HadoopUtils`? That way it would always be consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 818aae8eb16f682e089d8616e03b2873ca8ea64e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4d6f9aa45758753d7dfd55dd253c1c540626646 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701)
* aa9776ffae2b203d7c6980f4f7a32b70c26c6477 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750212036
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 472c9d41864d5c6834f0932a4a1cefca9a5e262d (Wed Dec 23 11:52:09 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 472c9d41864d5c6834f0932a4a1cefca9a5e262d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4d6f9aa45758753d7dfd55dd253c1c540626646 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701)
* aa9776ffae2b203d7c6980f4f7a32b70c26c6477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553858002
##########
File path: docs/_includes/generated/yarn_config_configuration.html
##########
@@ -14,6 +14,20 @@
<td>String</td>
<td>If configured, Flink will add this key to the resource profile of container request to Yarn. The value will be set to the value of external-resource.<resource_name>.amount.</td>
</tr>
+ <tr>
+ <td><h5>flink.hadoop.<hadoop_key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Hadoop configuration through prefix `flink.hadoop.`. Flink will remove the prefix to get hadoop_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml">core-default.xml</a> and <a href="https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml">hdfs-default.xml</a>) then set the hadoop_key and value to Hadoop configuration. For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.
+ </td>
+ </tr>
+ <tr>
+ <td><h5>flink.yarn.<key></h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>A general option to probe Yarn configuration through prefix `flink.yarn.`. Flink will remove the prefix `flink.` to get yarn_key (from <a href="https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-common/yarn-default.xml">yarn-default.xml</a>) then set the yarn_key and value to Yarn configuration. For example, flink.yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Flink configuration and convert to yarn.resourcemanager.container.liveness-monitor.interval-ms=300000 in Yarn configuration.
+ </td>
+ </tr>
Review comment:
@tillrohrmann I have added two options `flink.yarn.<key>` and `flink.hadoop.<key>` in `YarnConfigOptions` and auto generated related description in HTML document.
Then please take a look at this modification and evaluate the completion of this pr, thx!
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
Ok @tillrohrmann, We can slightly modify the `getYarnConfiguration` method in the `Utils` to call `HadoopUtils.getHadoopConfiguration(flinkConfig)`, as follows:
then `getYarnConfiguration` can be reused everywhere needed,as follows:
in `YarnClusterClientFactory` class
in `YarnResourceManagerDriver` class
Or another way is to keep the `getYarnConfiguration` method unchanged and add a method `loadYarnConfiguration` packing above logic in the `Utils` class, as follows：
then `loadYarnConfiguration` can be reused everywhere needed.
Which one do you think is appropriate? THX!
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
Ok @tillrohrmann, We can slightly modify the `getYarnConfiguration` method in the `Utils` class to call `HadoopUtils.getHadoopConfiguration(flinkConfig)`, as follows:
then `getYarnConfiguration` can be reused everywhere needed,as follows:
in `YarnClusterClientFactory` class
in `YarnResourceManagerDriver` class
Or another way is to keep the `getYarnConfiguration` method unchanged and add a new method `loadYarnConfiguration` in the `Utils` class, as follows：
then `loadYarnConfiguration` can be reused everywhere needed.
Which one do you think is appropriate? THX!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-755350173
@tillrohrmann Could you review code for this PR, thx!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][flink-yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 472c9d41864d5c6834f0932a4a1cefca9a5e262d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14477:
URL: https://github.com/apache/flink/pull/14477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa9776ffae2b203d7c6980f4f7a32b70c26c6477 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708)
* 1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 818aae8eb16f682e089d8616e03b2873ca8ea64e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741)
* ce120460bdf7625d4a588d546a6a8abe3a125273 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4d6f9aa45758753d7dfd55dd253c1c540626646 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553957897
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
I think we should still put this logic in the `Utils` class and then reuse it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r555111876
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
I would be in favour of only having a single method at them moment. Once we need to load a `YarnConfiguration` w/o the `HadoopConfiguration`, we can split the method. But until then, I would like to keep it simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r555671834
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -334,18 +334,32 @@
.stringType()
.noDefaultValue()
.withDescription(
- "A general option to probe Hadoop configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from <a href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml\">core-default.xml</a> "
- + "and <a href=\"https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml\">hdfs-default.xml</a>) then set the <key> and value to Hadoop configuration. "
- + "For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.");
+ Description.builder()
+ .text(
+ "A general option to probe Hadoop configuration through prefix 'flink.hadoop.'. Flink will remove the prefix to get <key> (from %s and %s) then set the <key> and value to Hadoop configuration."
+ + " For example, flink.hadoop.dfs.replication=5 in Flink configuration and convert to dfs.replication=5 in Hadoop configuration.",
+ link(
+ "https://hadoop.apache.org/docs/r2.4.1/hadoop-project-dist/hadoop-common/core-default.xml",
Review comment:
Yes, please update to link to the stable configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
}, {
"hash" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924",
"triggerID" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"triggerType" : "PUSH"
}, {
"hash" : "e94718c010b40322a4968d9e6130e90c5f6fd5e4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11939",
"triggerID" : "e94718c010b40322a4968d9e6130e90c5f6fd5e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e94718c010b40322a4968d9e6130e90c5f6fd5e4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11939)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-759327148
The test failures seem indeed to be unrelated. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-759188494
Hi @tillrohrmann, CI has failed but it seems to be unrelated to this pr, please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yuruguo commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r554300858
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -124,6 +125,8 @@ public YarnResourceManagerDriver(
super(flinkConfig, GlobalConfiguration.loadConfiguration(configuration.getCurrentDir()));
this.yarnConfig = new YarnConfiguration();
+ yarnConfig.addResource(HadoopUtils.getHadoopConfiguration(flinkConfig));
+ yarnConfig.addResource(Utils.getYarnConfiguration(flinkConfig));
Review comment:
Ok @tillrohrmann, We can slightly modify the `getYarnConfiguration` method in the `Utils` to call `HadoopUtils.getHadoopConfiguration(flinkConfig)`, as follows:
then `getYarnConfiguration` can be reused everywhere needed,as follows:
in `YarnClusterClientFactory` class
in `YarnResourceManagerDriver` class
Or another way is to keep the `getYarnConfiguration` method unchanged and add a method `loadYarnConfiguration` packing above logic in the `Utils` class, as follows：
then `loadYarnConfiguration` can be reused everywhere needed.
Which one do you think is appropriate? THX!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90ad920f7f511a6f66ffbc50f371343dad4f55b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486)
* d4d6f9aa45758753d7dfd55dd253c1c540626646 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14477:
URL: https://github.com/apache/flink/pull/14477#discussion_r553311496
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java
##########
@@ -77,6 +78,8 @@ public ApplicationId getClusterId(Configuration configuration) {
private YarnClusterDescriptor getClusterDescriptor(Configuration configuration) {
final YarnClient yarnClient = YarnClient.createYarnClient();
final YarnConfiguration yarnConfiguration = new YarnConfiguration();
+ yarnConfiguration.addResource(HadoopUtils.getHadoopConfiguration(configuration));
Review comment:
ok, thanks for the clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14477: [FLINK-16005][yarn] Support yarn and hadoop config override
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14477:
URL: https://github.com/apache/flink/pull/14477#issuecomment-750231028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11248",
"triggerID" : "472c9d41864d5c6834f0932a4a1cefca9a5e262d",
"triggerType" : "PUSH"
}, {
"hash" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11486",
"triggerID" : "90ad920f7f511a6f66ffbc50f371343dad4f55b1",
"triggerType" : "PUSH"
}, {
"hash" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11701",
"triggerID" : "d4d6f9aa45758753d7dfd55dd253c1c540626646",
"triggerType" : "PUSH"
}, {
"hash" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11708",
"triggerID" : "aa9776ffae2b203d7c6980f4f7a32b70c26c6477",
"triggerType" : "PUSH"
}, {
"hash" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11712",
"triggerID" : "1e34e16b05f86ea121ecefb4d7ff49f2b42b23a7",
"triggerType" : "PUSH"
}, {
"hash" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11741",
"triggerID" : "818aae8eb16f682e089d8616e03b2873ca8ea64e",
"triggerType" : "PUSH"
}, {
"hash" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891",
"triggerID" : "ce120460bdf7625d4a588d546a6a8abe3a125273",
"triggerType" : "PUSH"
}, {
"hash" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924",
"triggerID" : "6bd626ab6587a08718ae6c04a695074471c158f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce120460bdf7625d4a588d546a6a8abe3a125273 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11891)
* 6bd626ab6587a08718ae6c04a695074471c158f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11924)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org