[GitHub] spark pull request #23104: [SPARK-26138][SQL] Cross join requires push Local...

[guoxiaolongzte <gi...@git.apache.org>]

Github user guoxiaolongzte commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23104#discussion_r236143436
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -459,6 +459,7 @@ object LimitPushDown extends Rule[LogicalPlan] {
           val newJoin = joinType match {
             case RightOuter => join.copy(right = maybePushLocalLimit(exp, right))
             case LeftOuter => join.copy(left = maybePushLocalLimit(exp, left))
    +        case Cross => join.copy(left = maybePushLocalLimit(exp, left), right = maybePushLocalLimit(exp, right))
    --- End diff --
    
    I think, if when set spark.sql.crossJoin.enabled=true, if Inner join without condition, LeftOuter join without condition, RightOuter join without condition, FullOuter join without condition , limit should be pushed down on both sides, just like cross join limit in this PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org