You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2014/06/11 08:49:58 UTC

git commit: Revert "Switched to subprocess.Popen to get stdout streamed from"

Repository: mesos
Updated Branches:
  refs/heads/master bdb30b906 -> 2260df3e4


Revert "Switched to subprocess.Popen to get stdout streamed from"

This reverts commit 7013f47c3b59314db2b560d67edf1d01afd4a2db.


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2260df3e
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2260df3e
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2260df3e

Branch: refs/heads/master
Commit: 2260df3e4303fca12fc5430d9aae1912e268bb26
Parents: bdb30b9
Author: Vinod Kone <vi...@twitter.com>
Authored: Tue Jun 10 23:49:47 2014 -0700
Committer: Vinod Kone <vi...@twitter.com>
Committed: Tue Jun 10 23:49:47 2014 -0700

----------------------------------------------------------------------
 support/verify-reviews.py | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/2260df3e/support/verify-reviews.py
----------------------------------------------------------------------
diff --git a/support/verify-reviews.py b/support/verify-reviews.py
index 1a57c58..a84f9ce 100755
--- a/support/verify-reviews.py
+++ b/support/verify-reviews.py
@@ -40,10 +40,8 @@ if len(sys.argv) >= 5:
 
 def shell(command):
     print command
-    proc = subprocess.Popen(command, stderr=subprocess.STDOUT, shell=True)
-    (out, _) = proc.communicate()
-    if proc.returncode != 0:
-        raise subprocess.CalledProcessError(proc.returncode, command, out)
+    return subprocess.check_output(
+        command, stderr=subprocess.STDOUT, shell=True)
 
 
 def api(url, data=None):