You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2011/10/20 09:00:57 UTC
svn commit: r1186631 -
/tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Author: kfujino
Date: Thu Oct 20 07:00:57 2011
New Revision: 1186631
URL: http://svn.apache.org/viewvc?rev=1186631&view=rev
Log:
Avoid an unnecessary session ID change notice.
Notice of changed session ID by JvmRouteBinderValve is unnecessary to BackupManager.
In BackupManager, change of session ID is replicated by the call of a setId() method.
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java?rev=1186631&r1=1186630&r2=1186631&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java Thu Oct 20 07:00:57 2011
@@ -411,7 +411,7 @@ public class JvmRouteBinderValve extends
protected void sendSessionIDClusterBackup(Request request, String sessionId,
String newSessionID) {
CatalinaCluster c = getCluster();
- if (c != null) {
+ if (c != null && getManager(request) instanceof DeltaManager) {
SessionIDMessage msg = new SessionIDMessage();
msg.setOrignalSessionID(sessionId);
msg.setBackupSessionID(newSessionID);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1186631 - /tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Posted by Keiichi Fujino <kf...@apache.org>.
2011/10/21 Mark Thomas <ma...@apache.org>:
> On 20/10/2011 08:00, kfujino@apache.org wrote:
>> Author: kfujino
>> Date: Thu Oct 20 07:00:57 2011
>> New Revision: 1186631
>>
>> URL: http://svn.apache.org/viewvc?rev=1186631&view=rev
>> Log:
>> Avoid an unnecessary session ID change notice.
>
> Given this...
>> Notice of changed session ID by JvmRouteBinderValve is unnecessary to BackupManager.
>
>> + if (c != null && getManager(request) instanceof DeltaManager) {
>
> Might this be better to account for custom Manager implementations?
>
> if (c != null && !(getManager(request) instanceof BackupManager)) {
>
>
> Mark
Thanks for the review.
I committed on r1187149.
--
Keiichi.Fujino
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1186631 - /tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Posted by Mark Thomas <ma...@apache.org>.
On 20/10/2011 08:00, kfujino@apache.org wrote:
> Author: kfujino
> Date: Thu Oct 20 07:00:57 2011
> New Revision: 1186631
>
> URL: http://svn.apache.org/viewvc?rev=1186631&view=rev
> Log:
> Avoid an unnecessary session ID change notice.
Given this...
> Notice of changed session ID by JvmRouteBinderValve is unnecessary to BackupManager.
> + if (c != null && getManager(request) instanceof DeltaManager) {
Might this be better to account for custom Manager implementations?
if (c != null && !(getManager(request) instanceof BackupManager)) {
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org