You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2024/05/05 12:26:03 UTC

Re: [PR] [Feature] Introduce cluster management interface [paimon-webui]

SteNicholas commented on code in PR #200:
URL: https://github.com/apache/paimon-webui/pull/200#discussion_r1590298638


##########
paimon-web-server/src/main/resources/i18n/messages_en_US.properties:
##########
@@ -51,3 +51,4 @@ table.drop.error=Exception calling Paimon Catalog API to drop a table.
 table.rename.error=Exception calling Paimon Catalog API to rename a table.
 cdc.job.exist.error=Paimon CDC job exists.
 cdc.job.not.exist.error=Paimon CDC job is not exist.
+cluster.name.exist=The cluster name {0} already exists.

Review Comment:
   ```suggestion
   cluster.name.exist=This cluster name {0} already exists.
   ```
   To aligin the naming style of other name exist.



##########
paimon-web-server/src/main/resources/i18n/messages_zh_CN.properties:
##########
@@ -51,3 +51,4 @@ table.drop.error=\u8C03\u7528 Paimon API \u5220\u9664 Table \u65F6\u53D1\u751F\u
 table.rename.error=\u8C03\u7528 Paimon API \u91CD\u547D\u540D Table \u65F6\u53D1\u751F\u5F02\u5E38
 cdc.job.exist.error=paimon cdc\u4F5C\u4E1A\u5DF2\u5B58\u5728
 cdc.job.not.exist.error=paimon cdc\u4F5C\u4E1A\u4E0D\u5B58\u5728
+cluster.name.exist=\u8BE5\u96C6\u7FA4\u540D{0}\u5DF2\u7ECF\u5B58\u5728

Review Comment:
   Ditto.



##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/result/enums/Status.java:
##########
@@ -77,8 +77,13 @@ public enum Status {
     TABLE_DROP_ERROR(10510, "table.drop.error"),
     TABLE_RENAME_ERROR(10511, "table.rename.error"),
 
+    /** ------------cdc-----------------. */
     CDC_JOB_EXIST_ERROR(10601, "cdc.job.exist.error"),
-    CDC_JOB_NO_EXIST_ERROR(10602, "cdc.job.not.exist.error");
+    CDC_JOB_NO_EXIST_ERROR(10602, "cdc.job.not.exist.error"),
+
+    /** ------------cluster-----------------. */
+    CLUSTER_NOT_EXIST(10701, "cluster.not.exist"),

Review Comment:
   Any usage? If no, please remove this status.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org