You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/11 11:23:03 UTC
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #445:
fix(producer): UpdateNameServerAddress shoule be called before producer
start, or namesrvs list will be empty, lead to a panic
codecov-io edited a comment on issue #445: fix(producer): UpdateNameServerAddress shoule be called before producer start, or namesrvs list will be empty, lead to a panic
URL: https://github.com/apache/rocketmq-client-go/pull/445#issuecomment-597578208
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=h1) Report
> Merging [#445](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/af4067cae785c6e632df9f0f5c689e7d5aa86646?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #445 +/- ##
==========================================
- Coverage 24.82% 24.72% -0.11%
==========================================
Files 48 48
Lines 5547 5570 +23
==========================================
Hits 1377 1377
- Misses 3982 4003 +21
- Partials 188 190 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/445/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `29.12% <0%> (-0.18%)` | :arrow_down: |
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/445/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.19% <0%> (-0.23%)` | :arrow_down: |
| [producer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/445/diff?src=pr&el=tree#diff-cHJvZHVjZXIvb3B0aW9uLmdv) | `36% <0%> (-2.3%)` | :arrow_down: |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/445/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.37% <0%> (-0.04%)` | :arrow_down: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/445/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.23% <0%> (-0.01%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=footer). Last update [af4067c...cd17d7c](https://codecov.io/gh/apache/rocketmq-client-go/pull/445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services