You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/12/19 08:27:34 UTC

[GitHub] [echarts] Dingzhaocheng opened a new pull request #16243: Fix: Added property configuration to specify edge highlighting

Dingzhaocheng opened a new pull request #16243:
URL: https://github.com/apache/echarts/pull/16243


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   Added property configuration to specify edge highlighting
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   Source from this issue, need to solve the problem of highlighting on the specified side
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   According to the original method "highlight" of the highlighted node, pass in the dataType property in the payload
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [x] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   echartInstance.dispatchAction({ type: 'highlight', dataType: 'edge | node', dataIndex: number | number[] })
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997650114


   @Dingzhaocheng I didn't mean deleting these two folders. Just don't commit the change.
   
   Make sure in the `Files Changed` tab only having the changed source code and added test files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997650114


   @Dingzhaocheng I didn't mean deleting these two folders. Just don't commit the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Dingzhaocheng commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
Dingzhaocheng commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r771961658



##########
File path: src/view/Chart.ts
##########
@@ -141,18 +141,23 @@ class ChartView {
             plan: renderTaskPlan,
             reset: renderTaskReset
         });
-        this.renderTask.context = {view: this} as SeriesTaskContext;
+        this.renderTask.context = { view: this } as SeriesTaskContext;
     }
 
-    init(ecModel: GlobalModel, api: ExtensionAPI): void {}
+    init(ecModel: GlobalModel, api: ExtensionAPI): void { }

Review comment:
       Sorry, I modified and resubmitted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997349652


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997555602


   Please don't commit dist file. Just the changed source code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #16243: Support using dataType param to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-1005362287


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r772061191



##########
File path: .gitignore
##########
@@ -17,6 +17,7 @@ local.properties
 .class
 .settings/
 .loadpath
+*.lock

Review comment:
       `yarn.lock` shouldn't be ignored even though we don't use *__yarn__*.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r771918174



##########
File path: src/view/Chart.ts
##########
@@ -141,18 +141,23 @@ class ChartView {
             plan: renderTaskPlan,
             reset: renderTaskReset
         });
-        this.renderTask.context = {view: this} as SeriesTaskContext;
+        this.renderTask.context = { view: this } as SeriesTaskContext;
     }
 
-    init(ecModel: GlobalModel, api: ExtensionAPI): void {}
+    init(ecModel: GlobalModel, api: ExtensionAPI): void { }

Review comment:
       Please avoid using auto formatting tool on the source code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r775317294



##########
File path: src/data/helper/linkSeriesData.ts
##########
@@ -26,6 +26,7 @@ import { curry, each, assert, extend, map, keys } from 'zrender/src/core/util';
 import SeriesData from '../SeriesData';
 import { makeInner } from '../../util/model';
 import { SeriesDataType } from '../../util/types';
+import {warn} from "../../util/log";

Review comment:
       Unused code here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r771918174



##########
File path: src/view/Chart.ts
##########
@@ -141,18 +141,23 @@ class ChartView {
             plan: renderTaskPlan,
             reset: renderTaskReset
         });
-        this.renderTask.context = {view: this} as SeriesTaskContext;
+        this.renderTask.context = { view: this } as SeriesTaskContext;
     }
 
-    init(ecModel: GlobalModel, api: ExtensionAPI): void {}
+    init(ecModel: GlobalModel, api: ExtensionAPI): void { }

Review comment:
       Please avoid using auto formatting tool on the source code. They are noises to us when reviewing the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997555602


   Please don't commit dist and i18n folder. Just the changed source code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997697768


   > I'm sorry, I didn't get it right earlier. 😊
   
   Never mind. We are glad to having your contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r772056440



##########
File path: src/view/Chart.ts
##########
@@ -152,7 +152,8 @@ class ChartView {
      * Highlight series or specified data item.
      */
     highlight(seriesModel: SeriesModel, ecModel: GlobalModel, api: ExtensionAPI, payload: Payload): void {
-        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
+       const dataType = payload?.dataType || null;

Review comment:
       `|| null` seems to be not necessary




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Dingzhaocheng commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
Dingzhaocheng commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r772152731



##########
File path: .gitignore
##########
@@ -17,6 +17,7 @@ local.properties
 .class
 .settings/
 .loadpath
+*.lock

Review comment:
       Thanks, it has been modified

##########
File path: src/view/Chart.ts
##########
@@ -152,7 +152,8 @@ class ChartView {
      * Highlight series or specified data item.
      */
     highlight(seriesModel: SeriesModel, ecModel: GlobalModel, api: ExtensionAPI, payload: Payload): void {
-        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
+       const dataType = payload?.dataType || null;

Review comment:
       Thanks, it has been modified




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r774843458



##########
File path: src/view/Chart.ts
##########
@@ -152,14 +152,14 @@ class ChartView {
      * Highlight series or specified data item.
      */
     highlight(seriesModel: SeriesModel, ecModel: GlobalModel, api: ExtensionAPI, payload: Payload): void {
-        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
+        toggleHighlight(seriesModel.getData(payload && payload.dataType), payload, 'emphasis');

Review comment:
       If we need to do null checking. We should always do it at the place where it is used. In this case is before we passing it as a parameter to `toggleHighlight`. What if `seriesModel.getData()` has other methods to fetch the data if you do null checking in the `getLinkedData`. ? 
   
   Here is an example:
   
   ```ts
   const data = seriesModel.getData(payload && payload.dataType)
   if (!data) {
       if (__DEV__) {
           error(`Unkown dataType ${dataType}`);
       }
       return;
   }
   toggleHighlight(data, payload, 'emphasis');
   ```
   
   Null checking in the `getLinkedData` can be removed to simplify the code.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997353881


   Please dont commit yarn.lock


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Dingzhaocheng commented on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
Dingzhaocheng commented on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997680156


   > @Dingzhaocheng I didn't mean deleting these two folders. Just don't commit the change.
   > 
   > Make sure in the `Files Changed` tab only having the changed source code and added test files.
   
   I'm sorry, I didn't get it right earlier. 😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#issuecomment-997650114


   @Dingzhaocheng I didn't mean deleting these two folders. Just don't commit the change.
   
   Make sure in the files changed only having the changed source code and added test files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Dingzhaocheng commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
Dingzhaocheng commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r772163317



##########
File path: src/view/Chart.ts
##########
@@ -152,7 +152,7 @@ class ChartView {
      * Highlight series or specified data item.
      */
     highlight(seriesModel: SeriesModel, ecModel: GlobalModel, api: ExtensionAPI, payload: Payload): void {
-        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
+        toggleHighlight(seriesModel.getData(payload?.dataType), payload, 'emphasis');

Review comment:
       Thank you for your guidance, I have revised and submitted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r772826721



##########
File path: src/view/Chart.ts
##########
@@ -152,7 +152,7 @@ class ChartView {
      * Highlight series or specified data item.
      */
     highlight(seriesModel: SeriesModel, ecModel: GlobalModel, api: ExtensionAPI, payload: Payload): void {
-        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
+        toggleHighlight(seriesModel.getData(payload && payload.dataType), payload, 'emphasis');

Review comment:
       Developers may give wrong dataType that is not supported in the echarts. It's better to check if `data` exists here.
   
   Also `downplay` method should also add this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on a change in pull request #16243: Fix: Added property configuration to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16243:
URL: https://github.com/apache/echarts/pull/16243#discussion_r772159705



##########
File path: src/view/Chart.ts
##########
@@ -152,7 +152,7 @@ class ChartView {
      * Highlight series or specified data item.
      */
     highlight(seriesModel: SeriesModel, ecModel: GlobalModel, api: ExtensionAPI, payload: Payload): void {
-        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
+        toggleHighlight(seriesModel.getData(payload?.dataType), payload, 'emphasis');

Review comment:
       Using 
   
   ```js
   payload && payload.dataType
   ```
   
   Will be simpler on the generated code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #16243: Support using dataType param to specify edge highlighting

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #16243:
URL: https://github.com/apache/echarts/pull/16243


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org