[GitHub] Tibor17 commented on a change in pull request #204: [SUREFIRE-1602] Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #204: [SUREFIRE-1602] Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo
URL: https://github.com/apache/maven-surefire/pull/204#discussion_r238093294
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -103,7 +103,7 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull String startCl
         {
             file.deleteOnExit();
         }
-        Path parent = file.getParentFile().toPath();
+        Path parent = file.getParentFile().toPath().normalize();
 
 Review comment:
   It would be worth to copy [1] and integrate it in `surefire-its` as an integration test.
   [1]: https://github.com/daniel-kurzynski/reproduce-surefire-issue

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services