You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/30 08:01:31 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2975: Code improvement in rest client

pan3793 commented on code in PR #2975:
URL: https://github.com/apache/incubator-kyuubi/pull/2975#discussion_r910725594


##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/HttpClientFactory.java:
##########
@@ -45,7 +46,7 @@ public static CloseableHttpClient createHttpClient(RestClientConf conf) {
       sslSocketFactory = new SSLConnectionSocketFactory(sslContext, NoopHostnameVerifier.INSTANCE);
     } catch (Exception e) {
       LOG.error("Error: ", e);
-      throw new RuntimeException(e);
+      throw new KyuubiRestException("Failed to create HttpClient", e);

Review Comment:
   Always throw `KyuubiRestException`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org