You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/19 18:13:44 UTC

[GitHub] ccollins476ad commented on a change in pull request #237: Merge conflicting dependency conditionals

ccollins476ad commented on a change in pull request #237: Merge conflicting dependency conditionals
URL: https://github.com/apache/mynewt-newt/pull/237#discussion_r234726315
 
 

 ##########
 File path: newt/target/target.go
 ##########
 @@ -56,9 +56,13 @@ type Target struct {
 
 func NewTarget(basePkg *pkg.LocalPackage) *Target {
 	target := &Target{
-		TargetY: ycfg.YCfg{},
+		basePkg: basePkg,
 	}
-	target.Init(basePkg)
+
+	if basePkg.SyscfgY.Tree() == nil {
+		panic("ASD")
 
 Review comment:
   I really don't see what the problem is.  JK- I don't know how I missed that, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services