You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/14 12:00:10 UTC

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1118: DISPATCH-2039 Poison the memory pool so that ASAN works better with it

jiridanek opened a new pull request #1118:
URL: https://github.com/apache/qpid-dispatch/pull/1118


   TODO:
   * does this actually do the right thing?
   * is it necessary to instrument `unordered_move_stack` function?
   
   When there is a read or write to the poisoned area, the error message looks like
   
   ```
   ==15792==ERROR: AddressSanitizer: use-after-poison on address 0x611000034dd8 at pc 0x7fdaa75fc713 bp 0x7fff2d0c8d80 sp 0x7fff2d0c8d78
   14: WRITE of size 8 at 0x611000034dd8 thread T0
   14:     #0 0x7fdaa75fc712 in qd_hash_internal_remove_item /home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/../src/hash.c:131:30
   14:     #1 0x7fdaa75fb51d in qd_hash_free /home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/../src/hash.c:146:13
   [...]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] jiridanek merged pull request #1118: DISPATCH-2039 Poison the memory pool so that ASAN works better with it

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #1118:
URL: https://github.com/apache/qpid-dispatch/pull/1118


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] jiridanek commented on pull request #1118: DISPATCH-2039 Poison the memory pool so that ASAN works better with it

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1118:
URL: https://github.com/apache/qpid-dispatch/pull/1118#issuecomment-820419182


   @kgiusti This is imo a natural extension of https://issues.apache.org/jira/browse/DISPATCH-1225. I'll rebase this and if tests pass, I will unmark this as WIP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] jiridanek commented on pull request #1118: DISPATCH-2039 Poison the memory pool so that ASAN works better with it

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1118:
URL: https://github.com/apache/qpid-dispatch/pull/1118#issuecomment-820427255


   Uh, never mind, I did not realize #1119 is not yet merged. The tests are failing on that issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org