You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2012/09/18 18:30:07 UTC
[jira] [Created] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Steve Loughran created WHIRR-658:
------------------------------------
Summary: list-cluster could report "unknown cluster" when handed an unknown cluster name
Key: WHIRR-658
URL: https://issues.apache.org/jira/browse/WHIRR-658
Project: Whirr
Issue Type: Improvement
Reporter: Steve Loughran
when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated WHIRR-658:
---------------------------------
Component/s: core
Affects Version/s: 0.9.0
> list-cluster could report "unknown cluster" when handed an unknown cluster name
> -------------------------------------------------------------------------------
>
> Key: WHIRR-658
> URL: https://issues.apache.org/jira/browse/WHIRR-658
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Steve Loughran
>
> when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457935#comment-13457935 ]
Steve Loughran commented on WHIRR-658:
--------------------------------------
Reviewing the code, {{BlobClusterStateStore}} returns null on a missing cluster, which is a very different behaviour, one that will trigger NPEs in most code that uses it. It should throw this exception too.
> list-cluster could report "unknown cluster" when handed an unknown cluster name
> -------------------------------------------------------------------------------
>
> Key: WHIRR-658
> URL: https://issues.apache.org/jira/browse/WHIRR-658
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Steve Loughran
> Priority: Minor
>
> when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457926#comment-13457926 ]
Steve Loughran commented on WHIRR-658:
--------------------------------------
stack
{code}
bin/whirr list-cluster --config services/hdp/conf/ec2-micro/cluster.properties --cluster-name test
Running on provider aws-ec2 using identity AKIAJNX24OYZ7QLYHXYA
Exception in thread "main" java.io.FileNotFoundException: /Users/stevel/.whirr/test/instances (No such file or directory)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.<init>(FileInputStream.java:120)
at com.google.common.io.Files$1.getInput(Files.java:109)
at com.google.common.io.Files$1.getInput(Files.java:106)
at com.google.common.io.CharStreams$2.getInput(CharStreams.java:93)
at com.google.common.io.CharStreams$2.getInput(CharStreams.java:90)
at com.google.common.io.CharStreams.readLines(CharStreams.java:307)
at com.google.common.io.Files.readLines(Files.java:543)
at org.apache.whirr.state.FileClusterStateStore.load(FileClusterStateStore.java:55)
at org.apache.whirr.ClusterController.getInstances(ClusterController.java:305)
at org.apache.whirr.cli.command.ListClusterCommand.run(ListClusterCommand.java:79)
at org.apache.whirr.cli.command.ListClusterCommand.run(ListClusterCommand.java:67)
at org.apache.whirr.cli.Main.run(Main.java:69)
at org.apache.whirr.cli.Main.main(Main.java:102)
{code}
> list-cluster could report "unknown cluster" when handed an unknown cluster name
> -------------------------------------------------------------------------------
>
> Key: WHIRR-658
> URL: https://issues.apache.org/jira/browse/WHIRR-658
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Steve Loughran
>
> when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated WHIRR-658:
---------------------------------
Priority: Major (was: Minor)
Uprating due to risk of NPEs
> list-cluster could report "unknown cluster" when handed an unknown cluster name
> -------------------------------------------------------------------------------
>
> Key: WHIRR-658
> URL: https://issues.apache.org/jira/browse/WHIRR-658
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Steve Loughran
>
> when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457931#comment-13457931 ]
Steve Loughran commented on WHIRR-658:
--------------------------------------
the basic operations {{stop-services}} {{start-services}} and {{restart-services}} all have the same behaviour, though {{destroy-cluster}} isn't and instead just warns -so stays nicely idempotent.
A clean design here would be to have a specific exception {{UnknownClusterException extends IOException}} that gets thrown on a match failure -which is then handled differently by the specific entry points.
> list-cluster could report "unknown cluster" when handed an unknown cluster name
> -------------------------------------------------------------------------------
>
> Key: WHIRR-658
> URL: https://issues.apache.org/jira/browse/WHIRR-658
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Steve Loughran
> Priority: Minor
>
> when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-658) list-cluster could report "unknown
cluster" when handed an unknown cluster name
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated WHIRR-658:
---------------------------------
Priority: Minor (was: Major)
> list-cluster could report "unknown cluster" when handed an unknown cluster name
> -------------------------------------------------------------------------------
>
> Key: WHIRR-658
> URL: https://issues.apache.org/jira/browse/WHIRR-658
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.9.0
> Reporter: Steve Loughran
> Priority: Minor
>
> when you give {{whirr list-cluster}} an unknown cluster name, you get a file not found exception and a stack trace. This could be replaced with a "cluster not known" message
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira