You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/22 06:53:32 UTC
[GitHub] [age] Zahid07 opened a new pull request, #402: Changed age_split, age_replace, age_sin from STABLE TO IMMUTABLE
Zahid07 opened a new pull request, #402:
URL: https://github.com/apache/age/pull/402
Changed the 3 functions mentioned above to IMMUTABLE, as we are scanning the database to get the parameter of the functions but the functions themselves don't know that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] JoshInnis merged pull request #402: Changed age_split, age_replace, age_sin from STABLE TO IMMUTABLE
Posted by GitBox <gi...@apache.org>.
JoshInnis merged PR #402:
URL: https://github.com/apache/age/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] Zahid07 commented on pull request #402: Changed age_split, age_replace, age_sin from STABLE TO IMMUTABLE
Posted by GitBox <gi...@apache.org>.
Zahid07 commented on PR #402:
URL: https://github.com/apache/age/pull/402#issuecomment-1364475573
> Please fix your commit log entry for the PR to be descriptive of the change - what was changed and why. Once this is corrected, let us know so that we can review the PR for merging.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] Zahid07 commented on pull request #402: Changed age_split, age_replace, age_sin from STABLE TO IMMUTABLE
Posted by GitBox <gi...@apache.org>.
Zahid07 commented on PR #402:
URL: https://github.com/apache/age/pull/402#issuecomment-1364006237
> Please give a more clear and complete explanation why this is needed for these functions.
Changed the comment. Could you tell me if this is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #402: Changed age_split, age_replace, age_sin from STABLE TO IMMUTABLE
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #402:
URL: https://github.com/apache/age/pull/402#issuecomment-1363302550
Please give a more clear and complete explanation why this is needed for these functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #402: Changed age_split, age_replace, age_sin from STABLE TO IMMUTABLE
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #402:
URL: https://github.com/apache/age/pull/402#issuecomment-1364267932
Please fix your commit log entry for the PR to be descriptive of the change - what was changed and why. Once this is corrected, let us know so that we can review the PR for merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org