You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by dankilman <gi...@git.apache.org> on 2017/02/01 16:27:43 UTC

[GitHub] incubator-ariatosca pull request #64: ARIA-79-concurrent-modifications

GitHub user dankilman opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/64

    ARIA-79-concurrent-modifications

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca ARIA-79-concurrent-storage-modifications

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit 5b138a223c26e920a0285a912e9ebaba69ab8649
Author: Dan Kilman <da...@gigaspaces.com>
Date:   2017-01-30T14:49:00Z

    ARIA-79-concurrent-modifications

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #64: ARIA-79-concurrent-modifications

Posted by mxmrlv <gi...@git.apache.org>.
Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/64#discussion_r101535626
  
    --- Diff: aria/orchestrator/workflows/executor/process.py ---
    @@ -227,6 +227,8 @@ def _handle_task_failed_request(self, task_id, request, **kwargs):
             try:
                 self._apply_tracked_changes(task, request)
             except BaseException as e:
    +            e.message = \
    +                '{0} Remote task execution failed due: {1}'.format(str(e), request['exception'])
    --- End diff --
    
    change order, the tracked changes to log  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #64: ARIA-79-concurrent-modifications

Posted by dankilman <gi...@git.apache.org>.
Github user dankilman commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/64#discussion_r99083124
  
    --- Diff: aria/storage/base_model.py ---
    @@ -479,6 +479,7 @@ class NodeInstanceBase(ModelMixin):
         __tablename__ = 'node_instances'
         _private_fields = ['node_fk', 'host_fk']
     
    +    version_id = Column(Integer, nullable=False)
    --- End diff --
    
    think where version_id might also be applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #64: ARIA-79-concurrent-modifications

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-ariatosca/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---