You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org> on 2011/10/05 21:42:29 UTC
[jira] [Commented] (QPID-2442) make TemporaryQueue.delete perform
the delete on the broker
[ https://issues.apache.org/jira/browse/QPID-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121397#comment-13121397 ]
Robbie Gemmell commented on QPID-2442:
--------------------------------------
The actual change look reasonable to me, just have a couple nit-picks with the tests:
The failure messages in testUseFromAnotherSessionProhibited() hasnt been updated, so it is still talking about queue deletion:
{noformat}
fail("Expected JMSException : should not be able to delete while there are active consumers");
{noformat}
In testExplictTemporaryQueueDeletion() it would be good if the 2nd (successful) attempt deletion was verified to have had the desired effect on the broker, eg something like casting to an AMQSession and checking if the queue is still bound to an expected exchange (or for the Java broker, it could use JMX to check the queue MBean goes away).
> make TemporaryQueue.delete perform the delete on the broker
> -----------------------------------------------------------
>
> Key: QPID-2442
> URL: https://issues.apache.org/jira/browse/QPID-2442
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Affects Versions: M2, M2.1, M3, M4, 0.5, 0.6
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Attachments: 0001-QPID-2442-Make-0-10-TemporaryQueue-delete-and-Tempor.patch
>
>
> Session.createTemporaryQueue() actualy contacts the broker to create the queue before returning the temporaryQueue object, however TemporaryQueue.delete simply marks the object as deleted locally. This should be enhanced to delete the queue on the broker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org