You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/09 18:29:02 UTC
[GitHub] [superset] junlincc opened a new issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
junlincc opened a new issue #15067:
URL: https://github.com/apache/superset/issues/15067
1. Filter bar open by default if the dashboard has filters
When user open a dashboard that has filters attached, most likely the user will interact with those filters. with each time user collapse and open the bar, all charts on the dashboard get re-render. Leaving the filter bar open by default could prevent unnecessary performance issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-858096997
historically, in the dashboard area, there's a mysterious drop shadow under neath top level tab. As we are releasing dashboard native filter, Dashboard layout will be clearly divided into 2 areas -> filter bar and main dashboard. For consistency and better UIWe should either wrap the dashboard with drop shadow all around, or remove the one on top for constancy.
<img width="1786" alt="Screen Shot 2021-06-09 at 1 58 50 PM" src="https://user-images.githubusercontent.com/67837651/121427779-f5d2b100-c929-11eb-85f6-cafca7b719ea.png">
@michael-s-molina
*please convert comment into issue once PR is open, and tag the new issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857973506
3. the current highlighting color is not strong enough as indicator, let's change to a different one in product color scheme
@rusackas 🙏
https://projects.invisionapp.com/share/BNVBOEJRWQ2#/screens/398392085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #15067: [native-filters*6]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-859682916
> 1. change modal name from Filters configuration to Filters configuration and scoping
>
> @villebro
Done in https://github.com/apache/superset/pull/15115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857982941
4. change modal name from Filters configuration to Filters configuration and scoping
@villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857966709
2. Imagine user have 5 filters scoped to tab A, 25 filters scoped to tab B and tab C, and user is currently in tab A. 25 out of scope filters will hide in a collapsible section with a number indication for the total number of out of scope filters.
1) don't run query for those 25 out of scope filters until user open the collapsible section
2) if user want to interact with/select a filter value in filters that are scoped to tab B & C in tab A, tab B & C will be highlighted, all charts in tab A will be "greyed out" as an indication the interaction will not take effect. note: the apply button remains blue at the initial state, turn grey on click. edge case: what if user also select a value in one of the in scope filters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857966709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857982941
4. change modal name from Filters configuration to Filters configuration and scoping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857966709
2. Imagine user have 5 filters scoped to tab A, 25 filters scoped to tab B and tab C, and user is currently in tab A. 25 out of scope filters will hide in a collapsible section with a number indication for the total number of out of scope filters.
2.1 don't run query for those 25 out of scope filters until user open the collapsible section
2.2 if user want to interact with/select a filter value in filters that are scoped to tab B & C in tab A, tab B & C will be highlighted, all charts in tab A will be "greyed out" as an indication the interaction will not take effect. note: when value is selected in out of scope filter, the apply button remains blue at the initial state, turn grey on click. User have to switch to the associated tabs to click Apply again to run query. edge case: what if user also select a value in one of the in scope filters? @villebro @kgabryje @michael-s-molina ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #15067: [native-filters*6]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-858752845
> 1. Filter bar open by default if the dashboard has filters
> When user open a dashboard that has filters attached, most likely the user will interact with those filters. with each time user collapse and open the bar, all charts on the dashboard get re-render. Leaving the filter bar open by default could prevent unnecessary performance issue.
>
> @kgabryje 🙏
@junlincc It seems that it's already been implemented and is on master since June 7th.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857966709
2. Imagine user have 5 filters scoped to tab A, 25 filters scoped to tab B and tab C, and user is currently in tab A. 25 out of scope filters will hide in a collapsible section with a number indication for the total number of out of scope filters.
2.1 don't run query for those 25 out of scope filters until user open the collapsible section
2.2 if user want to interact with/select a filter value in filters that are scoped to tab B & C in tab A, tab B & C will be highlighted, all charts in tab A will be "greyed out" as an indication the interaction will not take effect. note: the apply button remains blue at the initial state, turn grey on click. edge case: what if user also select a value in one of the in scope filters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-857985568
5. Remove instant apply checkbox @villebro
*please convert comment into issue once PR is open, and tag issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed issue #15067: [native-filters*1]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
villebro closed issue #15067:
URL: https://github.com/apache/superset/issues/15067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15067: [native-filters][ux]Multiple dashboard native filter UX improvement
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15067:
URL: https://github.com/apache/superset/issues/15067#issuecomment-858096997
historically, in the dashboard area, there's a mysterious drop shadow under neath top level tab. As we are releasing dashboard native filter, Dashboard layout will be clearly divided into 2 areas -> filter bar and main dashboard. For consistency and better UIWe should either wrap the dashboard with drop shadow all around, or remove the one on top for constancy.
<img width="1786" alt="Screen Shot 2021-06-09 at 1 58 50 PM" src="https://user-images.githubusercontent.com/67837651/121427779-f5d2b100-c929-11eb-85f6-cafca7b719ea.png">
*please convert comment into issue once PR is open, and tag the new issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org