You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/20 14:47:38 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #465:
HDDS-2915. Unit check passes despite Maven error
adoroszlai opened a new pull request #465: HDDS-2915. Unit check passes despite Maven error
URL: https://github.com/apache/hadoop-ozone/pull/465
## What changes were proposed in this pull request?
Make unit check fail if the Maven command to run tests fails. The goal is to catch errors other than test failure (ie. the reported in [HDDS-2898](https://issues.apache.org/jira/browse/HDDS-2898)).
https://issues.apache.org/jira/browse/HDDS-2915
## How was this patch tested?
Verified that unit check fails due to current surefire exception:
```
2020-01-20T12:22:18.3344017Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test) on project hadoop-hdds-client: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test failed: java.lang.ClassFormatError: Illegal field name "org.apache.hadoop.hdds.scm.storage.TestBlockInputStream$this" in class org/apache/hadoop/hdds/scm/storage/TestBlockInputStream$DummyBlockInputStreamWithRetry -> [Help 1]
...
2020-01-20T12:22:18.9654829Z ##[error]Docker run failed with exit code 1
```
https://github.com/adoroszlai/hadoop-ozone/runs/398891595
Verified that after fixing HDDS-2898, unit test passes:
https://github.com/adoroszlai/hadoop-ozone/runs/399028351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #465: HDDS-2915. Unit
check passes despite Maven error
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #465: HDDS-2915. Unit check passes despite Maven error
URL: https://github.com/apache/hadoop-ozone/pull/465#issuecomment-577348330
Thanks @xiaoyuyao for reviewing and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #465: HDDS-2915. Unit
check passes despite Maven error
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #465: HDDS-2915. Unit check passes despite Maven error
URL: https://github.com/apache/hadoop-ozone/pull/465#issuecomment-577347044
LGTM, +1. I will merge it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #465: HDDS-2915. Unit
check passes despite Maven error
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #465: HDDS-2915. Unit check passes despite Maven error
URL: https://github.com/apache/hadoop-ozone/pull/465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org