You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/06 00:20:54 UTC
[GitHub] [airflow] dmoore247 opened a new pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
dmoore247 opened a new pull request #19437:
URL: https://github.com/apache/airflow/pull/19437
This pull request adds a Databricks PySpark job as an Airflow Task to the existing Databricks example.
the PySpark job task was difficult to find for me so I'm adding the short example I developed back to the community (and my future self). This example also adds a parameter and an egg file library for richness and completeness.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #19437:
URL: https://github.com/apache/airflow/pull/19437#discussion_r744040837
##########
File path: airflow/providers/databricks/example_dags/example_databricks.py
##########
@@ -71,4 +72,17 @@
libraries=[{'jar': 'dbfs:/lib/etl-0.1.jar'}],
)
# [END howto_operator_databricks_named]
- notebook_task >> spark_jar_task
+
+ # [START howto_operator_databricks_pyspark]
Review comment:
These `# [START/END howto_operator_...]` tags are used as references in the operator documentation so the docs can display code snippets of the related example DAG between these `START` and `END` tags. Using these tags keeps the examples and the operator docs in sync. Would you be willing to add some context around this new task and how it relates to the `DatabricksSubmitRunOperator `?
You can check out how similar tags are used for the existing operators in the Databricks operator documentation [here](https://github.com/apache/airflow/edit/main/docs/apache-airflow-providers-databricks/operators.rst).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #19437:
URL: https://github.com/apache/airflow/pull/19437#discussion_r744040837
##########
File path: airflow/providers/databricks/example_dags/example_databricks.py
##########
@@ -71,4 +72,17 @@
libraries=[{'jar': 'dbfs:/lib/etl-0.1.jar'}],
)
# [END howto_operator_databricks_named]
- notebook_task >> spark_jar_task
+
+ # [START howto_operator_databricks_pyspark]
Review comment:
These `# [START/END howto_operator_...]` tags are used as references in the operator documentation so the docs can display code snippets of the related example DAG between these `START` and `END` tags. Using these tags keeps the examples and the operator docs in sync. Would you be willing to add some context around this new task and how it relates to the `DatabricksSubmitRunOperator`?
You can check out how similar tags are used for the existing operators in the Databricks operator documentation [here](https://github.com/apache/airflow/edit/main/docs/apache-airflow-providers-databricks/operators.rst).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dmoore247 closed pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
dmoore247 closed pull request #19437:
URL: https://github.com/apache/airflow/pull/19437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19437:
URL: https://github.com/apache/airflow/pull/19437#discussion_r744282599
##########
File path: airflow/providers/databricks/example_dags/example_databricks.py
##########
@@ -71,4 +72,17 @@
libraries=[{'jar': 'dbfs:/lib/etl-0.1.jar'}],
)
# [END howto_operator_databricks_named]
- notebook_task >> spark_jar_task
+
+ # [START howto_operator_databricks_pyspark]
Review comment:
Oh yeah That should be indeed updated in the Databricks howto: https://airflow.apache.org/docs/apache-airflow-providers-databricks/stable/operators.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dmoore247 commented on a change in pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
dmoore247 commented on a change in pull request #19437:
URL: https://github.com/apache/airflow/pull/19437#discussion_r744919597
##########
File path: airflow/providers/databricks/example_dags/example_databricks.py
##########
@@ -71,4 +72,17 @@
libraries=[{'jar': 'dbfs:/lib/etl-0.1.jar'}],
)
# [END howto_operator_databricks_named]
- notebook_task >> spark_jar_task
+
+ # [START howto_operator_databricks_pyspark]
Review comment:
@josh-fell @potiuk Thanks for the pointer... I'll see about making that update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dmoore247 commented on a change in pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
dmoore247 commented on a change in pull request #19437:
URL: https://github.com/apache/airflow/pull/19437#discussion_r745224043
##########
File path: airflow/providers/databricks/example_dags/example_databricks.py
##########
@@ -71,4 +72,17 @@
libraries=[{'jar': 'dbfs:/lib/etl-0.1.jar'}],
)
# [END howto_operator_databricks_named]
- notebook_task >> spark_jar_task
+
+ # [START howto_operator_databricks_pyspark]
Review comment:
My colleague has an open [PR](https://github.com/apache/airflow/pull/19156) that would overlap with this one. I'd like to withdraw this PR and re-submit once the other PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19437: Add Databricks PySpark job example DAG task, update cluster config
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19437:
URL: https://github.com/apache/airflow/pull/19437#issuecomment-962290408
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org