You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/01 18:15:39 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1866: Add a UUID to the server's ZooLock

ctubbsii commented on a change in pull request #1866:
URL: https://github.com/apache/accumulo/pull/1866#discussion_r568037243



##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -38,9 +40,13 @@
 import org.slf4j.LoggerFactory;
 
 public class ZooLock implements Watcher {
-  private static final Logger log = LoggerFactory.getLogger(ZooLock.class);
+  private static final Logger LOG = LoggerFactory.getLogger(ZooLock.class);

Review comment:
       In general, static final variables are typically all uppercase. I'm surprised we don't adopt that convention for more of these loggers. I don't think it matters much, though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org