You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/08 12:59:44 UTC
[GitHub] [maven-shared-utils] kwin opened a new pull request, #96: [MSHARED-1079] add build() method and document toString() method
kwin opened a new pull request, #96:
URL: https://github.com/apache/maven-shared-utils/pull/96
improve Javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] asfgit closed pull request #96: [MSHARED-1079] add build() method and document toString() method
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #96: [MSHARED-1079] add build() method and document toString() method
URL: https://github.com/apache/maven-shared-utils/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] kwin commented on a diff in pull request #96: [MSHARED-1079] add build() method and document toString() method
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #96:
URL: https://github.com/apache/maven-shared-utils/pull/96#discussion_r892825837
##########
src/main/java/org/apache/maven/shared/utils/logging/MessageBuilder.java:
##########
@@ -21,6 +21,8 @@
/**
* Message builder that supports configurable styling.
+ * An instance of this interface can be retrieved with {@link MessageUtils#buffer()}.
+ * After the message has been build with any of the append methods its content can be retrieved with {@link #build()}.
Review Comment:
Thanks, replaced by "constructed" in https://github.com/apache/maven-shared-utils/pull/96/commits/8aca4bb4e4ccbda4a2c463e63899311b000be93b as "build/built" is kind of overloaded here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] kwin commented on a diff in pull request #96: [MSHARED-1079] add build() method and document toString() method
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #96:
URL: https://github.com/apache/maven-shared-utils/pull/96#discussion_r892825837
##########
src/main/java/org/apache/maven/shared/utils/logging/MessageBuilder.java:
##########
@@ -21,6 +21,8 @@
/**
* Message builder that supports configurable styling.
+ * An instance of this interface can be retrieved with {@link MessageUtils#buffer()}.
+ * After the message has been build with any of the append methods its content can be retrieved with {@link #build()}.
Review Comment:
Thanks, replaced by "constructed" in https://github.com/apache/maven-shared-utils/pull/96/commits/35eb1e3a0dd029fb872b153fc04c847089b07377 as "build/built" is kind of overloaded here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] pzygielo commented on a diff in pull request #96: [MSHARED-1079] add build() method and document toString() method
Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #96:
URL: https://github.com/apache/maven-shared-utils/pull/96#discussion_r892754850
##########
src/main/java/org/apache/maven/shared/utils/logging/MessageBuilder.java:
##########
@@ -21,6 +21,8 @@
/**
* Message builder that supports configurable styling.
+ * An instance of this interface can be retrieved with {@link MessageUtils#buffer()}.
+ * After the message has been build with any of the append methods its content can be retrieved with {@link #build()}.
Review Comment:
_build, built, **built**_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org