You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/09/24 16:34:38 UTC
[GitHub] couchdb-fauxton pull request: [WIP] Headerbar buttons & API Bar re...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/535
[WIP] Headerbar buttons & API Bar refactor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton queryoptions-tray
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/535.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #535
----
commit 62d872691d3f9993101b274ca1162b011c717b2a
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-09-23T10:09:13Z
rename queryoptions file
we don't use camel case for file names
commit 6dce8cae0495a25a1b3b4bd7bd90e390bc4adef0
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-09-23T10:41:48Z
refactor header buttons, fix minor issues
this unifies two of our 4 snowflake headerbutton implementations.
the elements used are our standart headerbuttons. once the api-url
button is converted we can delete a lot of additional custom css.
- convert add-db button
- convert query-option-tray button
- fix bug in add-db button where the activated state of the
button was not set
commit fb2d74a8888d9862532e1e36e31a39b3945bf598
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-09-24T11:14:32Z
fix loading of zeroclipboard
the swf was not loaded when no change to the element happened, e.g.
a static element.
additionally add a simple callback function to confirm a copy
commit 66442eef4e4184856db66858b721a604937e4cbb
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-09-24T13:48:25Z
convert api bar to react
- delete superfluous snowflake css
- use headertoggle button
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#issuecomment-144130226
Gimme just a few more mins + I'll give it one more look over :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#issuecomment-144131378
Couple of minor style things:
- there used to be more space between the icons and text for "Add New Database" and "API URL"
- the icons are a little too high now; they used to be horizontally aligned with the text.
<img width="302" alt="screen shot 2015-09-29 at 10 36 42 am" src="https://cloud.githubusercontent.com/assets/512116/10172811/2e97098e-6696-11e5-94c1-28ee3455d46c.png">
- Same for Query Options on the Database pages.
<img width="274" alt="screen shot 2015-09-29 at 10 38 21 am" src="https://cloud.githubusercontent.com/assets/512116/10172823/42fe300a-6696-11e5-9296-3b2d6cf2f09c.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#issuecomment-144133082
Other than those, looks good! +1 with the style fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#issuecomment-144130090
@benkeen +1 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#issuecomment-144719965
@benkeen fixed the icon position, good eye!
merged as:
ebd9ced89d27de297526acf74ebad88f1c6a6711
685d6f82d60f7d020c64bdf5010dc1f84d77bf5e
d1d98323d5145af0129ba84c28a5b567f409044d
69b686e31cc0ea9f4c7eeb254dc061447995f2c9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#discussion_r40663222
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -14,20 +14,33 @@ define([
'app',
'api',
'react',
- 'addons/fauxton/components',
+ 'addons/fauxton/components.react',
'ace/ace',
'plugins/beautify'
],
-function (app, FauxtonAPI, React, Components, ace, beautifyHelper) {
+function (app, FauxtonAPI, React, FauxtonComponents, ace, beautifyHelper) {
var ReactCSSTransitionGroup = React.addons.CSSTransitionGroup;
var ToggleHeaderButton = React.createClass({
+ getDefaultProps: function () {
--- End diff --
@benkeen added!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Headerbar buttons & API Bar refactor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/535#issuecomment-144041994
@benkeen adressed the comments, had to rebase as i had a merge conflict with your recent header-flexbox work and github lost all comments. :(
here is the other comment i answered: https://github.com/robertkowalski/couchdb-fauxton/commit/6dce8cae0495a25a1b3b4bd7bd90e390bc4adef0#commitcomment-13490635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---