[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r137805760
  
    --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/AnchoredWordCount.java ---
    @@ -0,0 +1,138 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.starter;
    +
    +import org.apache.storm.Config;
    +import org.apache.storm.LocalCluster;
    +import org.apache.storm.spout.SpoutOutputCollector;
    +import org.apache.storm.task.TopologyContext;
    +import org.apache.storm.topology.BasicOutputCollector;
    +import org.apache.storm.topology.OutputFieldsDeclarer;
    +import org.apache.storm.topology.TopologyBuilder;
    +import org.apache.storm.topology.base.BaseBasicBolt;
    +import org.apache.storm.topology.base.BaseRichSpout;
    +import org.apache.storm.tuple.Fields;
    +import org.apache.storm.tuple.Tuple;
    +import org.apache.storm.tuple.Values;
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +import java.util.Random;
    +import java.util.UUID;
    +
    +
    +public class AnchoredWordCount {
    +    public static class RandomSentenceSpout extends BaseRichSpout {
    +        private static final Logger LOG = LoggerFactory.getLogger(RandomSentenceSpout.class);
    +
    +        SpoutOutputCollector _collector;
    +        Random _rand;
    --- End diff --
    
    Can we try and follow the style conventions in place in 2.x?  It would make the upmerge a lot simpler.


---