[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #431: introduce reliability tests on elastic

[GitBox <gi...@apache.org>]

fabriziofortino commented on a change in pull request #431:
URL: https://github.com/apache/jackrabbit-oak/pull/431#discussion_r769499632



##########
File path: oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnectionRule.java
##########
@@ -52,28 +53,19 @@
 public class ElasticConnectionRule extends ExternalResource {
 
     private static final Logger LOG = LoggerFactory.getLogger(ElasticConnectionRule.class);
-    private ElasticConnection elasticConnection;
-    private final String elasticConnectionString;
+
     private static final String INDEX_PREFIX = "elastic_test";
     private static final String PLUGIN_DIGEST = "060117b4150c87274d9cff0925ec16e714f28a40906a53a2cd2a23322bbb3189";
     private static boolean useDocker = false;
 
+    private final String elasticConnectionString;
+
     public ElasticConnectionRule(String elasticConnectionString) {
         this.elasticConnectionString = elasticConnectionString;
     }
 
     public ElasticsearchContainer elastic;
 
-    /*
-    Executed once in the test class' execution lifecycle, after the execution of apply()

Review comment:
       I thought the same. But this was actually not needed. I confirm all tests in a class run against the same docker container.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org