[jira] [Commented] (SLING-12153) Update maven-archiver and maven-filtering

["Julian Sedding (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785985#comment-17785985 ] 

Julian Sedding commented on SLING-12153:
----------------------------------------

The dependency in question is {{org.eclipse.sisu:org.eclipse.sisu.plexus:0.0.0.M2a}}, which pulls in {{com.google.guava:guava:10.0.1}}. After updating both the {{maven-archiver}} and {{maven-filtering}} dependencies, the dependency to {{org.eclipse.sisu:org.eclipse.sisu.plexus}} becomes a test dependency and thus no longer appears in the transitive dependency graph.

The exception stack trace was:
{noformat}
java.lang.NoSuchMethodError: 'com.google.common.cache.CacheBuilder com.google.common.cache.CacheBuilder.maximumSize(long)'
        at com.github.fge.jsonschema.core.load.SchemaLoader.<init>(SchemaLoader.java:105)
        at com.github.fge.jsonschema.main.JsonSchemaFactory.<init>(JsonSchemaFactory.java:138)
        at com.github.fge.jsonschema.main.JsonSchemaFactoryBuilder.freeze(JsonSchemaFactoryBuilder.java:139)
        at com.github.fge.jsonschema.main.JsonSchemaFactory.byDefault(JsonSchemaFactory.java:113)
        at org.apache.sling.feature.maven.Preprocessor.<init>(Preprocessor.java:66)
        at org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:79)
        at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.loadExtensions(Maven3XProjectResolver.java:391)
        at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.lambda$doResolveProject$2(Maven3XProjectResolver.java:153)
        at org.jetbrains.idea.maven.server.Maven3ServerEmbedder.executeWithSessionScope(Maven3ServerEmbedder.java:289)
        at org.jetbrains.idea.maven.server.Maven3ServerEmbedder.executeWithMavenSession(Maven3ServerEmbedder.java:232)
        at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.doResolveProject(Maven3XProjectResolver.java:117)
        at org.jetbrains.idea.maven.server.utils.Maven3XProjectResolver.resolveProjects(Maven3XProjectResolver.java:88)
        at org.jetbrains.idea.maven.server.Maven3XServerEmbedder.resolveProjects(Maven3XServerEmbedder.java:528)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
        at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
        at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
        at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
        at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:587)
        at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:828)
        at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:705)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
        at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:704)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)
{noformat}

The problem is a signature change from {{CacheBuilder#maximumSize(int)}} to {{CacheBuilder#maximumSize(long)}} somewhere between guava 10.0.1 and more modern versions.

> Update maven-archiver and maven-filtering
> -----------------------------------------
>
>                 Key: SLING-12153
>                 URL: https://issues.apache.org/jira/browse/SLING-12153
>             Project: Sling
>          Issue Type: Improvement
>          Components: Maven Plugins and Archetypes
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>            Priority: Minor
>             Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> [~jsedding] noticed that the plug-in brings in older versions of the maven-archiver and maven-filtering. Those dependencies 
> {quote}drag an ancient guava version into the classpath via a transitive dependency that was moved into "test" scope in newer versions of these two libraries{quote}
> This causes various problems with IntelliJ and Eclipse integration. And upgrading dependencies is always a good idea :-)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)