You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/29 01:54:16 UTC
[GitHub] [rocketmq] mrhbj opened a new pull request #3542: Fix pullconsumer notes
mrhbj opened a new pull request #3542:
URL: https://github.com/apache/rocketmq/pull/3542
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Git-Yang commented on pull request #3542: Fix pullconsumer notes
Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #3542:
URL: https://github.com/apache/rocketmq/pull/3542#issuecomment-981224964
Can you create an ISSUE for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mrhbj closed pull request #3542: Fix pullconsumer notes
Posted by GitBox <gi...@apache.org>.
mrhbj closed pull request #3542:
URL: https://github.com/apache/rocketmq/pull/3542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mrhbj commented on pull request #3542: Fix pullconsumer notes
Posted by GitBox <gi...@apache.org>.
mrhbj commented on pull request #3542:
URL: https://github.com/apache/rocketmq/pull/3542#issuecomment-981225692
> Can you create an ISSUE for this PR?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3542: Fix pullconsumer notes
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3542:
URL: https://github.com/apache/rocketmq/pull/3542#issuecomment-981231221
[](https://coveralls.io/builds/44586282)
Coverage increased (+0.02%) to 54.401% when pulling **d941051018289fa7d640ee947e9dfc9ad73dc7da on mrhbj:fix-pullconsumer-notes** into **a75c74234915f1673c635639e6a70e4c25dcd740 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org