You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by aa...@apache.org on 2023/03/17 08:22:54 UTC

[rocketmq-clients] branch master updated: Print more info for client stats

This is an automated email from the ASF dual-hosted git repository.

aaronai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
     new 514056c2 Print more info for client stats
514056c2 is described below

commit 514056c2f98691d8643f9540a216e7b6854f5b81
Author: Aaron Ai <ya...@gmail.com>
AuthorDate: Fri Mar 17 15:54:22 2023 +0800

    Print more info for client stats
---
 .../org/apache/rocketmq/client/java/impl/ClientManagerImpl.java     | 6 ++++--
 .../main/java/org/apache/rocketmq/client/java/misc/Utilities.java   | 6 ++++++
 .../java/org/apache/rocketmq/client/java/misc/UtilitiesTest.java    | 6 ++++++
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
index 7ab2f9b6..2ae5f5e4 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/ClientManagerImpl.java
@@ -63,6 +63,7 @@ import org.apache.rocketmq.client.java.misc.ClientId;
 import org.apache.rocketmq.client.java.misc.ExecutorServices;
 import org.apache.rocketmq.client.java.misc.MetadataUtils;
 import org.apache.rocketmq.client.java.misc.ThreadFactoryImpl;
+import org.apache.rocketmq.client.java.misc.Utilities;
 import org.apache.rocketmq.client.java.route.Endpoints;
 import org.apache.rocketmq.client.java.rpc.Context;
 import org.apache.rocketmq.client.java.rpc.RpcClient;
@@ -394,8 +395,9 @@ public class ClientManagerImpl extends ClientManager {
             () -> {
                 try {
                     log.info("Start to log statistics, clientVersion={}, clientWrapperVersion={}, "
-                            + "clientEndpoints={}, clientId={}", MetadataUtils.getVersion(),
-                        MetadataUtils.getWrapperVersion(), client.getEndpoints(), clientId);
+                            + "clientEndpoints={}, os description=[{}], java description=[{}], clientId={}",
+                        MetadataUtils.getVersion(), MetadataUtils.getWrapperVersion(), client.getEndpoints(),
+                        Utilities.getOsDescription(), Utilities.getJavaDescription(), clientId);
                     client.doStats();
                 } catch (Throwable t) {
                     log.error("Exception raised during statistics logging, clientId={}", clientId, t);
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/misc/Utilities.java b/java/client/src/main/java/org/apache/rocketmq/client/java/misc/Utilities.java
index 9557e1e1..35916a5b 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/misc/Utilities.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/misc/Utilities.java
@@ -297,4 +297,10 @@ public class Utilities {
             return null;
         }
     }
+
+    public static String getJavaDescription() {
+        return System.getProperty("java.vm.vendor")
+            + " " + System.getProperty("java.vm.name")
+            + " " + System.getProperty("java.vm.version");
+    }
 }
diff --git a/java/client/src/test/java/org/apache/rocketmq/client/java/misc/UtilitiesTest.java b/java/client/src/test/java/org/apache/rocketmq/client/java/misc/UtilitiesTest.java
index 41f408da..b59c377a 100644
--- a/java/client/src/test/java/org/apache/rocketmq/client/java/misc/UtilitiesTest.java
+++ b/java/client/src/test/java/org/apache/rocketmq/client/java/misc/UtilitiesTest.java
@@ -61,4 +61,10 @@ public class UtilitiesTest {
         assertNotNull(stackTrace);
         assertTrue(stackTrace.length() > 0);
     }
+
+    @Test
+    public void testGetJavaDescription() {
+        final String javaDescription = Utilities.getJavaDescription();
+        assertNotNull(javaDescription);
+    }
 }
\ No newline at end of file