You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/06 03:51:19 UTC

[GitHub] [arrow] kou opened a new pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

kou opened a new pull request #7364:
URL: https://github.com/apache/arrow/pull/7364


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#issuecomment-640510233


   Restarted the RTools builds because the errors looked transient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#discussion_r436991040



##########
File path: ci/scripts/cpp_test.sh
##########
@@ -32,13 +32,36 @@ export LD_LIBRARY_PATH=${ARROW_HOME}/${CMAKE_INSTALL_LIBDIR:-lib}:${LD_LIBRARY_P
 # to retrieve metadata. Disable this so that S3FileSystem tests run faster.
 export AWS_EC2_METADATA_DISABLED=TRUE
 
+ctest_options=()
 case "$(uname)" in
   Linux)
     n_jobs=$(nproc)
     ;;
   Darwin)
     n_jobs=$(sysctl -n hw.ncpu)
     ;;
+  MINGW*)
+    n_jobs=${NUMBER_OF_PROCESSORS:-1}
+    exclude_tests="gandiva-internals-test"

Review comment:
       Done: https://issues.apache.org/jira/browse/ARROW-9072




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on a change in pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#discussion_r436590761



##########
File path: ci/scripts/cpp_test.sh
##########
@@ -32,13 +32,36 @@ export LD_LIBRARY_PATH=${ARROW_HOME}/${CMAKE_INSTALL_LIBDIR:-lib}:${LD_LIBRARY_P
 # to retrieve metadata. Disable this so that S3FileSystem tests run faster.
 export AWS_EC2_METADATA_DISABLED=TRUE
 
+ctest_options=()
 case "$(uname)" in
   Linux)
     n_jobs=$(nproc)
     ;;
   Darwin)
     n_jobs=$(sysctl -n hw.ncpu)
     ;;
+  MINGW*)
+    n_jobs=${NUMBER_OF_PROCESSORS:-1}
+    exclude_tests="gandiva-internals-test"

Review comment:
       I assume we'll need a follow-up jira to fix these tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on a change in pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#discussion_r436995841



##########
File path: ci/scripts/cpp_test.sh
##########
@@ -32,13 +32,36 @@ export LD_LIBRARY_PATH=${ARROW_HOME}/${CMAKE_INSTALL_LIBDIR:-lib}:${LD_LIBRARY_P
 # to retrieve metadata. Disable this so that S3FileSystem tests run faster.
 export AWS_EC2_METADATA_DISABLED=TRUE
 
+ctest_options=()
 case "$(uname)" in
   Linux)
     n_jobs=$(nproc)
     ;;
   Darwin)
     n_jobs=$(sysctl -n hw.ncpu)
     ;;
+  MINGW*)
+    n_jobs=${NUMBER_OF_PROCESSORS:-1}
+    exclude_tests="gandiva-internals-test"

Review comment:
       Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs closed pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #7364:
URL: https://github.com/apache/arrow/pull/7364


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#issuecomment-639975189


   https://issues.apache.org/jira/browse/ARROW-9052


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#issuecomment-640882163


   Merging on green.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org