[jira] [Commented] (MYFACES-3749) columnClasses not working correctly in DataTable Component

["Paul Nicolucci (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762446#comment-13762446 ] 

Paul Nicolucci commented on MYFACES-3749:
-----------------------------------------

Actually looking at this again I think I have a more simple solution since we already know we are rendering a column without waiting until we get to encodeColumnChildren as well we'll need to apply the same logic to the before and after column methods.  I'll post another patch soon.
                
> columnClasses not working correctly in DataTable Component
> ----------------------------------------------------------
>
>                 Key: MYFACES-3749
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3749
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.18, 2.1.12
>            Reporter: Paul Nicolucci
>         Attachments: MyFaces-3749.patch
>
>
> Sample JSF page:
> <h:outputStylesheet library="css" name="table-style.css"  />
> <h:dataTable value="#{dataTableBean.sampleList}" var="o"
> styleClass="order-table"
> headerClass="order-table-header"
> rowClasses="order-table-odd-row,order-table-even-row"
> columnClasses="col0,col1,col2,col3"
> >
> <f:param id="testParam" value="TESTER" />
>             
> <h:column>
> <f:facet name="header">Column1</f:facet>
> #{o.str1}
> </h:column>
>     
> <h:column>
> <f:facet name="header">Column2</f:facet>
> #{o.str2}
> </h:column>
>     
> <h:column>
> <f:facet name="header">Column3</f:facet>
> #{o.str3}
> </h:column>
>     
> <h:column>
> <f:facet name="header">Column4</f:facet>
> #{o.str4}
> </h:column>
> </h:dataTable>  
> Sample CSS:
> .order-table{   
> border-collapse:collapse;
> }
> .order-table-header{
> text-align:center;
> }
> .order-table-odd-row{
> text-align:center;
> }
> .order-table-even-row{
> text-align:center;
> }
> .col0{
> text-align:center;
> }
> .col1{
> text-align:center;
> }
> .col2{
> text-align:center;
> }
> .col3{
> text-align:center;
> }
> Problem description:
> The rendered output of one of the rows of the above page is the following:
> <tr class="order-table-odd-row"><td class="col1">
> test1
> </td><td class="col2">
> test2
> </td><td class="col3">
> test3
> </td><td class="">
> test4
> </td></tr>
> As you can see the last column has no definition of a columnClass ( class="" ).   The same page works if we remove the <f:param/> definition from within the 
> <h:dataTable/>.  If the f:param tag is removed then I see that all of the columns have a defined class as expected ( the number of columns is less than or equal to the 
> defined columnClasses so each of the columns should have a class defined. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira