[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4646: Add global settings for VM migration flags

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #4646:
URL: https://github.com/apache/cloudstack/pull/4646#discussion_r718463432



##########
File path: engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java
##########
@@ -1759,8 +1764,11 @@ public void processConnect(final Host host, final StartupCommand cmd, final bool
             if (cmd instanceof StartupRoutingCommand) {
                 if (((StartupRoutingCommand)cmd).getHypervisorType() == HypervisorType.KVM || ((StartupRoutingCommand)cmd).getHypervisorType() == HypervisorType.LXC) {
                     Map<String, String> params = new HashMap<String, String>();
-                    params.put(Config.RouterAggregationCommandEachTimeout.toString(), _configDao.getValue(Config.RouterAggregationCommandEachTimeout.toString()));
                     params.put(Config.MigrateWait.toString(), _configDao.getValue(Config.MigrateWait.toString()));
+                    params.put(ROUTER_AGGREGATION_COMMAND_EACH_TIMEOUT, _configDao.getValue(ROUTER_AGGREGATION_COMMAND_EACH_TIMEOUT));
+                    params.put(KVM_VM_MIGRATE_SPEED_STRING, _configDao.getValue(KVM_VM_MIGRATE_SPEED_STRING));

Review comment:
       KVM_VM_MIGRATE_SPEED is a cluster-level setting, but global config is uses here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org