You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2022/07/06 18:51:00 UTC
[jira] [Commented] (CASSANDRA-17695) Fix AbstractCell#toString throws MarshalException for cell in collection
[ https://issues.apache.org/jira/browse/CASSANDRA-17695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563394#comment-17563394 ]
Josh McKenzie commented on CASSANDRA-17695:
-------------------------------------------
[ASF CI Results]
Branch: 4.1, build number: 84
butler url: [https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/Cassandra-4.1]
jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-4.1/84/]
JIRA: CASSANDRA-17695
commit url: [https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=a9725b681b948f2122f3d48b96a5c4e7403d2c39]
affected paths:
* src/java/org/apache/cassandra/db/rows/AbstractCell.java
* CHANGES.txt
* test/unit/org/apache/cassandra/db/CellTest.java
Build Result: UNSTABLE
Passing Tests: 48211
Failing Tests: 26
||Test|Failures|JIRA|
|org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.testSelectOnMultiIndexOnCollectionsWithNull|11 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.upgrade.MixedModeAvailabilityV30Test.testAvailability|13 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-offheap.auth_test.TestAuth.test_system_auth_ks_is_alterable|3 of 81|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestAuth*%22]|
|org.apache.cassandra.cql3.validation.operations.SelectTest.containsFilteringForClusteringKeys|2 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest.repair_tests.incremental_repair_test.TestIncRepair.test_multiple_repair|4 of 81|CASSANDRA-11268?|
|org.apache.cassandra.net.ProxyHandlerConnectionsTest.suddenDisconnect-compression|3 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestUpgrade_current_3_0_x_To_indev_4_1_x.test_bootstrap|1 of 81|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestUpgrade*%22]|
|org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.testIndexOnRegularColumnInsertExpiringColumnWithFlush|9 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.validation.entities.TupleTypeTest.testNestedTuple|12 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.test.SchemaTest.readRepair|21 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest.rebuild_test.TestRebuild.test_resumable_rebuild|1 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.testIndexesOnNonStaticColumnsWhereSchemaIncludesStaticColumns|2 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.net.ConnectionTest.testTimeout-cdc|1 of 81|CASSANDRA-16677?|
|org.apache.cassandra.distributed.test.CASTest.testConflictingWritesWithStaleRingInformation|21 of 81|CASSANDRA-17461?|
|org.apache.cassandra.distributed.upgrade.CompactStoragePagingTest.testPagingWithCompactStorage|7 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.test.RepairErrorsTest.testRemoteStreamFailure|3 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.ViewComplexTTLTest.testUpdateColumnInViewPKWithTTLWithFlush[3]|19 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.utils.concurrent.SemaphoreTest.testUnfair|1 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.net.ProxyHandlerConnectionsTest.testExpireSome-compression|7 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.test.SchemaTest.readRepairWithCompaction|23 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.ViewComplexLivenessTest.testUnselectedColumnWithExpiredLivenessInfoWithoutFlush[3]|1 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.ViewComplexTTLTest.terminated successfully|5 of 81|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
> Fix AbstractCell#toString throws MarshalException for cell in collection
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-17695
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17695
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core
> Reporter: Yifan Cai
> Assignee: Francisco Guerrero
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> AbstractCell#toString is broken when calling on some cells in multi-cell collections.
> With the following types are unmarshallable: [date, duration, smallint, time, tinyint].
> The test to discover the unmarshallable types is
> {code:java}
> @Test
> public void testUnmarshallableInMulticellCollection()
> {
> List<CQL3Type.Native> unmarshallableTypes = new ArrayList<>();
> for (CQL3Type.Native nativeType : CQL3Type.Native.values())
> {
> ColumnMetadata c = fakeColumn("c", MapType.getInstance(Int32Type.instance, nativeType.getType(), true));
> BufferCell cell = BufferCell.tombstone(c, 0, 4, CellPath.create(ByteBufferUtil.bytes(4)));
> try
> {
> cell.toString();
> }
> catch (MarshalException m)
> {
> unmarshallableTypes.add(nativeType);
> }
> }
> System.out.println("Unmarshallable types: " + unmarshallableTypes);
> }
> {code}
> At the first sight, the error is caused by trying to deserialize the values of the tombstone cells. The values are empty, hence the failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org