You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/05/11 14:37:50 UTC
Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
Review request for cloudstack, Prasanna Santhanam and sangeetha hariharan.
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs
-----
test/integration/smoke/test_affinity_groups.py e0e1a17
tools/marvin/marvin/integration/lib/base.py ecdc841
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request 11067: Automation: Add testcases for
Affinity/Anti-Affinity Rules
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/#review22460
-----------------------------------------------------------
Ship it!
3c0c6cb
- Prasanna Santhanam
On June 26, 2013, 5:11 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11067/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 5:11 p.m.)
>
>
> Review request for cloudstack, Prachi Damle, sangeetha hariharan, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-2254
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add testcases for Affinity/Anti-Affinity Rules
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 503ed64
>
> Diff: https://reviews.apache.org/r/11067/diff/
>
>
> Testing
> -------
>
> The tests which are not skipped are working.
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 11067: Automation: Add testcases for
Affinity/Anti-Affinity Rules
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated June 26, 2013, 5:11 p.m.)
Review request for cloudstack, Prachi Damle, sangeetha hariharan, and Prasanna Santhanam.
Changes
-------
Latest patch for review
Bugs: CLOUDSTACK-2254
Repository: cloudstack-git
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 503ed64
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/#review21798
-----------------------------------------------------------
Girish, I'm only able to apply patch 1 that adds the test_affinity_groups module. Subsequent patches fail. Can you squash all the patches starting from the first patch that adds the tests for affinity groups into one patch please? Sorry for the delays.
- Prasanna Santhanam
On June 10, 2013, 10:03 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11067/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 10:03 a.m.)
>
>
> Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha hariharan.
>
>
> Description
> -------
>
> Add testcases for Affinity/Anti-Affinity Rules
>
>
> This addresses bug CLOUDSTACK-2254.
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11067/diff/
>
>
> Testing
> -------
>
> The tests which are not skipped are working.
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated June 10, 2013, 10:03 a.m.)
Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha hariharan.
Changes
-------
Fixed the patch by removing trailing whitespaces
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/#review21511
-----------------------------------------------------------
Unable to apply this :(
~/workspace/cloudstack/incubator-cloudstack(branch:master*) ยป git am -s patch/11067.patch tsp@cloud-2
Applying: CLOUDSTACK-2254: Automation: Add automation for Affinity and Anti Affinity rules
/Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:16: trailing whitespace.
def setUpClass(cls):
/Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:53: trailing whitespace.
/Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:70: trailing whitespace.
/Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:77: trailing whitespace.
/Users/tsp/workspace/cloudstack/incubator-cloudstack/.git/rebase-apply/patch:78: trailing whitespace.
def create_aff_grp(self, api_client=None, aff_grp=None,
error: test/integration/component/test_affinity_groups.py: does not exist in index
Patch failed at 0001 CLOUDSTACK-2254: Automation: Add automation for Affinity and Anti Affinity rules
- Prasanna Santhanam
On May 29, 2013, 7:56 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11067/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 7:56 a.m.)
>
>
> Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha hariharan.
>
>
> Description
> -------
>
> Add testcases for Affinity/Anti-Affinity Rules
>
>
> This addresses bug CLOUDSTACK-2254.
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11067/diff/
>
>
> Testing
> -------
>
> The tests which are not skipped are working.
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated May 29, 2013, 7:56 a.m.)
Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha hariharan.
Changes
-------
Update the patches with testcases for listAffinityGroups API
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated May 29, 2013, 7:46 a.m.)
Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha hariharan.
Changes
-------
Updated the patch so that only testcases related to createAffinityGroups API are in the patch.
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
test/integration/smoke/test_affinity_groups.py e0e1a17
tools/marvin/marvin/integration/lib/base.py ec1c34e
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated May 28, 2013, 6:28 a.m.)
Review request for cloudstack, Prachi Damle, Prasanna Santhanam, and sangeetha hariharan.
Changes
-------
There is only one test in this patch. Is there an updated patch with the skipped tests completed?
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py ec1c34e
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated May 21, 2013, 3:06 p.m.)
Review request for cloudstack, Prasanna Santhanam and sangeetha hariharan.
Changes
-------
branch included
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py ec1c34e
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/
-----------------------------------------------------------
(Updated May 21, 2013, 8:04 a.m.)
Review request for cloudstack, Prasanna Santhanam and sangeetha hariharan.
Changes
-------
Moved the tests from smoke to component.
Description
-------
Add testcases for Affinity/Anti-Affinity Rules
This addresses bug CLOUDSTACK-2254.
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py ec1c34e
Diff: https://reviews.apache.org/r/11067/diff/
Testing
-------
The tests which are not skipped are working.
Thanks,
Girish Shilamkar
Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity
Rules
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11067/#review20564
-----------------------------------------------------------
Girish, thanks for the patch. I'm afraid the intentions are not clear for smoke and component suites. I've recorded them here:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python#Marvin-TestingwithPython-ExistingTests
Smoke tests only test the happy-path of the feature. Simple usecases that ensure that the feature is not outright broken are included here. Typically these can be run quickly from the developer environment itself using simulator or devcloud. Component is where all the in-depth test cases from test plans should be.
Can you please move these tests to the component suites?
- Prasanna Santhanam
On May 11, 2013, 12:37 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11067/
> -----------------------------------------------------------
>
> (Updated May 11, 2013, 12:37 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and sangeetha hariharan.
>
>
> Description
> -------
>
> Add testcases for Affinity/Anti-Affinity Rules
>
>
> This addresses bug CLOUDSTACK-2254.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_affinity_groups.py e0e1a17
> tools/marvin/marvin/integration/lib/base.py ecdc841
>
> Diff: https://reviews.apache.org/r/11067/diff/
>
>
> Testing
> -------
>
> The tests which are not skipped are working.
>
>
> Thanks,
>
> Girish Shilamkar
>
>