You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2026/07/02 03:06:58 UTC
[PR] chore!(rust): remove DataFusion driver [arrow-adbc]
lidavidm opened a new pull request, #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#issuecomment-4861886383
CC @eitsupi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#issuecomment-4898827340
I updated the PR body to link to the new repo instead of just saying "a third party".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on code in PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#discussion_r3525798948
##########
.github/workflows/rust.yml:
##########
@@ -244,7 +227,7 @@ jobs:
-p arrow-schema \
-p arrow-select
- # If the lock file was updated, run the tests except for adbc_datafusion
+ # If the lock file was updated, run the tests
if ! git diff --quiet Cargo.lock; then
- cargo test --all-targets --all-features --workspace --exclude adbc_datafusion
+ cargo test --all-targets --all-features --workspace
fi
Review Comment:
Of course, there's still the advantage of testing for the latest arrow immediately before Dependabot updating the lock file, so it might be worth keeping (although it could be annoying if it suddenly starts failing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#discussion_r3525794009
##########
.github/workflows/rust.yml:
##########
@@ -244,7 +227,7 @@ jobs:
-p arrow-schema \
-p arrow-select
- # If the lock file was updated, run the tests except for adbc_datafusion
+ # If the lock file was updated, run the tests
if ! git diff --quiet Cargo.lock; then
- cargo test --all-targets --all-features --workspace --exclude adbc_datafusion
+ cargo test --all-targets --all-features --workspace
fi
Review Comment:
Hmm, ideally we can still test with an older version of Arrow though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#discussion_r3525796436
##########
.github/workflows/rust.yml:
##########
@@ -244,7 +227,7 @@ jobs:
-p arrow-schema \
-p arrow-select
- # If the lock file was updated, run the tests except for adbc_datafusion
+ # If the lock file was updated, run the tests
if ! git diff --quiet Cargo.lock; then
- cargo test --all-targets --all-features --workspace --exclude adbc_datafusion
+ cargo test --all-targets --all-features --workspace
fi
Review Comment:
Ah, but you have that test already with minimal-versions. Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore!(rust): remove DataFusion driver [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#discussion_r3532793527
##########
docs/source/rust/quickstart.rst:
##########
@@ -23,14 +23,17 @@ Here we'll briefly tour using ADBC with the `DataFusion`_ driver.
.. _DataFusion: https://datafusion.apache.org/
+.. note:: The DataFusion driver is maintained by a third party. We're using it here since we don't maintain any Rust-based drivers directly.
Review Comment:
```suggestion
.. note:: The DataFusion driver is maintained by a third party, the ADBC Driver Foundry (https://adbc-drivers.org). We're using it here since we don't maintain any Rust-based drivers directly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org