You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Valery Vyrva (JIRA)" <ji...@apache.org> on 2008/03/03 06:22:50 UTC
[jira] Created: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Redefine method "public boolean equals(Object o)" for simplify object instance compare.
---------------------------------------------------------------------------------------
Key: JXPATH-119
URL: https://issues.apache.org/jira/browse/JXPATH-119
Project: Commons JXPath
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Valery Vyrva
Priority: Trivial
For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
I will try to attach archive with svn-diff to this issue.
P.S.
Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Posted by "Valery Vyrva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578163#action_12578163 ]
Valery Vyrva commented on JXPATH-119:
-------------------------------------
We pars JXPath expression and use parsing result for creating instances of our objects that depends of JXPath elements.
No, in attached svn-diff method hashCode is not implemented, because we only be in need of compare instances of JXPath elements in deep. If it is needed, I can implements and hashCode method too.
Yes I can implement comparation in Comparators, but I think that is not nice.
P.S.
Sorry for long delay - I forget for start watching this issue.
> Redefine method "public boolean equals(Object o)" for simplify object instance compare.
> ---------------------------------------------------------------------------------------
>
> Key: JXPATH-119
> URL: https://issues.apache.org/jira/browse/JXPATH-119
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Valery Vyrva
> Priority: Trivial
> Attachments: JXPath.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
> I will try to attach archive with svn-diff to this issue.
> P.S.
> Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated JXPATH-119:
---------------------------------
Fix Version/s: post-1.3
Reopening as Later is not good JIRA workflow. Setting to post-1.3; ie "Later".
> Redefine method "public boolean equals(Object o)" for simplify object instance compare.
> ---------------------------------------------------------------------------------------
>
> Key: JXPATH-119
> URL: https://issues.apache.org/jira/browse/JXPATH-119
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Valery Vyrva
> Priority: Trivial
> Fix For: post-1.3
>
> Attachments: JXPath.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
> I will try to attach archive with svn-diff to this issue.
> P.S.
> Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577843#action_12577843 ]
Matt Benson commented on JXPATH-119:
------------------------------------
If I may ask, what are you doing with these objects that necessitates the implementation of equals()? Also, note that if this is committed, either you or I should really implement hashCode as well, a fairly more complex task (and one that would require consensus on an acceptable implementation, so don't go doing it just yet). Is it possible you could implement these as Comparators instead, to externalize them from the JXPath classes themselves?
> Redefine method "public boolean equals(Object o)" for simplify object instance compare.
> ---------------------------------------------------------------------------------------
>
> Key: JXPATH-119
> URL: https://issues.apache.org/jira/browse/JXPATH-119
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Valery Vyrva
> Priority: Trivial
> Attachments: JXPath.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
> I will try to attach archive with svn-diff to this issue.
> P.S.
> Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Benson resolved JXPATH-119.
--------------------------------
Resolution: Later
I am as yet unconvinced about this, so I'm not going to let this hold up v1.3.
> Redefine method "public boolean equals(Object o)" for simplify object instance compare.
> ---------------------------------------------------------------------------------------
>
> Key: JXPATH-119
> URL: https://issues.apache.org/jira/browse/JXPATH-119
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Valery Vyrva
> Priority: Trivial
> Attachments: JXPath.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
> I will try to attach archive with svn-diff to this issue.
> P.S.
> Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Posted by "Valery Vyrva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valery Vyrva updated JXPATH-119:
--------------------------------
Attachment: JXPath.zip
svn-diff with changes for revision 632307
> Redefine method "public boolean equals(Object o)" for simplify object instance compare.
> ---------------------------------------------------------------------------------------
>
> Key: JXPATH-119
> URL: https://issues.apache.org/jira/browse/JXPATH-119
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Valery Vyrva
> Priority: Trivial
> Attachments: JXPath.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
> I will try to attach archive with svn-diff to this issue.
> P.S.
> Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JXPATH-119) Redefine method "public boolean
equals(Object o)" for simplify object instance compare.
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell reopened JXPATH-119:
----------------------------------
> Redefine method "public boolean equals(Object o)" for simplify object instance compare.
> ---------------------------------------------------------------------------------------
>
> Key: JXPATH-119
> URL: https://issues.apache.org/jira/browse/JXPATH-119
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Valery Vyrva
> Priority: Trivial
> Fix For: post-1.3
>
> Attachments: JXPath.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> For simplify object instance comparing we proposition redefine the method "equals" in some classes of JXPath project.
> I will try to attach archive with svn-diff to this issue.
> P.S.
> Sorry for my bad English.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.