[jira] [Commented] (DRILL-8240) Revisit clone of log4j Strings class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555478#comment-17555478 ] 

ASF GitHub Bot commented on DRILL-8240:
---------------------------------------

pjfanning opened a new pull request, #2574:
URL: https://github.com/apache/drill/pull/2574

   # [DRILL-8240](https://issues.apache.org/jira/browse/DRILL-8240): remove Strings.java and add dependency on log4j-api instead
   
   ## Description
   
   See DRILL-8240 for full description. Apache Hive depends on some log4j-api code. log4j-api is just the API and not the log4j implementation. We should provide the log4j-api jar when using Hive code.
   
   ## Documentation
   
   None expected.
   
   ## Testing
   
   CI build
   




> Revisit clone of log4j Strings class
> ------------------------------------
>
>                 Key: DRILL-8240
>                 URL: https://issues.apache.org/jira/browse/DRILL-8240
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Functions - Hive
>    Affects Versions: 1.20.1
>            Reporter: PJ Fanning
>            Priority: Major
>
> See https://issues.apache.org/jira/browse/DRILL-8044 for background.
> The code added there is now out of date. After the log4j panic late last year, 5 commits were made to modify the real log4j class and these are missing from the Drill copy.
> Compare https://github.com/apache/logging-log4j2/commits/rel/2.17.2/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java to https://github.com/apache/logging-log4j2/commits/rel/2.14.1/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java
> The Drill copy is based on Log4J 2.14.1. Every commit in 2021 and 2022 is missing from the Drill copy.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)