You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tomvanbussel (via GitHub)" <gi...@apache.org> on 2025/06/11 12:28:53 UTC
[PR] [SPARK-49110][SQL] Fix reading metadata columns for tables with CHAR columns [spark]
tomvanbussel opened a new pull request, #51154:
URL: https://github.com/apache/spark/pull/51154
### What changes were proposed in this pull request?
This PR modifies `SubqueryAlias` to propagate the metadata output of its child if the is a `Project` injected by `ApplyCharTypePadding`.
### Why are the changes needed?
This is needed because with these changes it is not possible to read metadata columns when reading a table with a CHAR column when read-side padding is enabled. In the case the plan is `SubqueryAlias(Project(LeafNode)))`, so without this patch the metadata output is not propagated.
### Does this PR introduce _any_ user-facing change?
Yes, there will be more cases in which the metadata columns can be accessed, and users will no longer get an exception in these cases.
### How was this patch tested?
Added a case to `MetadataColumnSuite`.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49110][SQL] Fix reading metadata columns for tables with CHAR columns [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51154:
URL: https://github.com/apache/spark/pull/51154#issuecomment-3314285203
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49110][SQL] Fix reading metadata columns for tables with CHAR columns [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #51154: [SPARK-49110][SQL] Fix reading metadata columns for tables with CHAR columns
URL: https://github.com/apache/spark/pull/51154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org