[jira] [Commented] (FALCON-1573) Supply user-defined properties to Oozie workflows during schedule

["Ajay Yadava (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987302#comment-14987302 ] 

Ajay Yadava commented on FALCON-1573:
-------------------------------------

Hi [~ddcprg],

This is a very good contribution and right at the core of falcon. Pretty neat as well, kudos to you! 

I agree with your idea to use entity XML as the base but I think allowing the properties provided at the command line to override those defined in the entity XML will be a much more useful or intuitive behavior. If the user is giving the same property again at the command line then I think it should be treated as an explicit intent to override. IMO, the chances of making mistakes in xml because of copy paste are more than doing the same on command line. This will allow the user to have both, default fallback option and ability to override it. Thoughts?


P.S. - you need to change the status to patch available, by clicking the "Submit Patch" button, as we filter issues on that status to review JIRAs.

> Supply user-defined properties to Oozie workflows during schedule
> -----------------------------------------------------------------
>
>                 Key: FALCON-1573
>                 URL: https://issues.apache.org/jira/browse/FALCON-1573
>             Project: Falcon
>          Issue Type: New Feature
>          Components: oozie
>    Affects Versions: trunk
>            Reporter: Daniel del Castillo
>            Priority: Minor
>         Attachments: FALCON-1573-v1.patch
>
>
> The work in FALCON-1434 added the ability to specify properties for the purpose of enabling scheduler selection. However, this could be more generally useful as a means for users to submit custom properties that will be visible in Oozie workflows.
> This will enable users to reference properties in the entity XML itself and passing these properties down to workflows. For example, a process scheduled with the command:
> {code}
> bin/falcon entity -schedule -type process -name helloFalconProcess -properties custom.property:HEY
> {code}
> can reference the property _custom.property_ in the process XML as
> {code:xml}
> <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> <process name="helloFalconProcess" xmlns="uri:falcon:process:0.1">
>   ...
>   <properties>
>     ...
>     <property name="customProperty" value="${coord:conf('custom.property')}"/>
>     ...
>   </properties>
>   ...
> </process>
> {code}
> An Oozie workflow can then easily make use of such property:
> {code:xml}
> <workflow-app xmlns="uri:oozie:workflow:0.4" name="hello-falcon-wf">
>   ...
>     <java>
>       ...
>       <arg>--customValue=${customProperty}</arg>
>       ...
>     </java>
>     ...
> </workflow-app>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)