You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Tim McConnell (JIRA)" <ji...@apache.org> on 2007/03/12 18:35:09 UTC
[jira] Created: (GERONIMO-2958) MyFaces annotation support
MyFaces annotation support
--------------------------
Key: GERONIMO-2958
URL: https://issues.apache.org/jira/browse/GERONIMO-2958
Project: Geronimo
Issue Type: Sub-task
Security Level: public (Regular issues)
Reporter: Tim McConnell
Assigned To: Tim McConnell
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (GERONIMO-2958) MyFaces annotation support
Posted by David Jencks <da...@yahoo.com>.
On Mar 13, 2007, at 9:07 AM, Jacek Laskowski wrote:
> On 3/12/07, David Jencks <da...@yahoo.com> wrote:
>
>> I guess this could be named less ambiguously :-)
>>
>> This is for processing annotations in jsf managed beans and dealing
>> with myfaces so geronimo can inject the dependencies and call the
>> lifecycle methods as specified by annotations in the jsf managed bean
>> classes. See also MYFACES-1559
>
> Ah, it's about annotation support in JSF managed beans. Does it really
> apply to MyFaces only? What about JSF RI impl? Won't it work on
> Geronimo?
Well, no. We need a contract between the jsf framework and geronimo
so geronimo can do the dependency injection and lifecycle methods.
This contract is not part of the spec and I don't like the one the ri
uses. I'm negotiating with the myfaces team to try to get a better
one.
thanks
david jencks
>
>> Any clearer :-) ?
>
> Yes, sir! ;-)
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.JacekLaskowski.pl
Re: [jira] Created: (GERONIMO-2958) MyFaces annotation support
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 3/12/07, David Jencks <da...@yahoo.com> wrote:
> I guess this could be named less ambiguously :-)
>
> This is for processing annotations in jsf managed beans and dealing
> with myfaces so geronimo can inject the dependencies and call the
> lifecycle methods as specified by annotations in the jsf managed bean
> classes. See also MYFACES-1559
Ah, it's about annotation support in JSF managed beans. Does it really
apply to MyFaces only? What about JSF RI impl? Won't it work on
Geronimo?
> Any clearer :-) ?
Yes, sir! ;-)
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
Re: [jira] Created: (GERONIMO-2958) MyFaces annotation support
Posted by David Jencks <da...@yahoo.com>.
On Mar 12, 2007, at 4:44 PM, Jacek Laskowski wrote:
> On 3/12/07, Tim McConnell (JIRA) <ji...@apache.org> wrote:
>> MyFaces annotation support
>> --------------------------
>>
>> Key: GERONIMO-2958
>> URL: https://issues.apache.org/jira/browse/
>> GERONIMO-2958
>> Project: Geronimo
>> Issue Type: Sub-task
>> Security Level: public (Regular issues)
>> Reporter: Tim McConnell
>> Assigned To: Tim McConnell
>
> What are MyFaces annotations?
I guess this could be named less ambiguously :-)
This is for processing annotations in jsf managed beans and dealing
with myfaces so geronimo can inject the dependencies and call the
lifecycle methods as specified by annotations in the jsf managed bean
classes. See also MYFACES-1559
Any clearer :-) ?
thanks
david jencks
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.JacekLaskowski.pl
Re: [jira] Created: (GERONIMO-2958) MyFaces annotation support
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 3/12/07, Tim McConnell (JIRA) <ji...@apache.org> wrote:
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public (Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
What are MyFaces annotations?
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl
[jira] Updated: (GERONIMO-2958) MyFaces annotation support
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMO-2958:
------------------------------------
Attachment: GERONIMO-2958-1.patch
First patch to produce classfinder from managed beans--working on the getConfigFileURL() method to find the faces config file from the three possible locations....
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2958) MyFaces annotation support
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481006 ]
David Jencks commented on GERONIMO-2958:
----------------------------------------
implemented and hooked up to jetty in rev 518452. Seems to work -- at least we are creating all the jsf managed beans fine. Uses the interface for bean lifecycle we negotiated with the MyFaces team, and many thanks to them for their cooperation!
This also cleans up construction of Modules and removes an unused and apparently unneeded method from ModuleBuilderExtension.
Still need to integrate with tomcat.
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch, GERONIMO-2958-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2958) MyFaces annotation support
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480191 ]
David Jencks commented on GERONIMO-2958:
----------------------------------------
I committed some initial code in rev 517399. This is a myfaces support jar and a myfaces config. The config starts OK if you add it to the jetty server.
This code needs you to build myfaces yourself after applying https://issues.apache.org/jira/secure/attachment/12353143/MYFACES-1559-2.patch from https://issues.apache.org/jira/browse/MYFACES-1559
This is NOT hooked into the main build. To try it out you need to build modules/geronimo-myfaces and configs/myfaces individually.
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2958) MyFaces annotation support
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481162 ]
David Jencks commented on GERONIMO-2958:
----------------------------------------
rev 518635, fix a bug where every proxy to LifecycleProviderFactoryGBean was registering a new ApplicationIndexedLifecycleProviderFactory, thus preventing our shiny new framework from actually creating any managed beans for MyFaces.
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch, GERONIMO-2958-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2958) MyFaces annotation support
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480225 ]
David Jencks commented on GERONIMO-2958:
----------------------------------------
Committed modified version of patchs 1 and 2 in rev 517461. I hooked it up to create a LifecycleProviderGBean if a jsf config file is found. 100% untested, but it builds for me.
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2958) MyFaces annotation support
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480376 ]
David Jencks commented on GERONIMO-2958:
----------------------------------------
I rearranged your code quite a bit and applied the 3rd patch in rev 517673. Previously in rev 517658 I added the GBeanInfo stuff so its actually a gbean.
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch, GERONIMO-2958-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-2958) MyFaces annotation support
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell closed GERONIMO-2958.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0-M6
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0-M6
>
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch, GERONIMO-2958-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2958) MyFaces annotation support
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMO-2958:
------------------------------------
Attachment: GERONIMO-2958-3.patch
Refined the search method used to locate the various for the faces configuration files (via the three possible specifications). Works much better now--only thing remaining should be the proper handling of JSF 1.1 DTD files and 1.2 XSD files which I'll finish tomorrow......
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch, GERONIMO-2958-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2958) MyFaces annotation support
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMO-2958:
------------------------------------
Attachment: GERONIMO-2958-2.patch
getConfigFileURL() method when not using javax.faces.CONFIG_FILES
> MyFaces annotation support
> --------------------------
>
> Key: GERONIMO-2958
> URL: https://issues.apache.org/jira/browse/GERONIMO-2958
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Attachments: GERONIMO-2958-1.patch, GERONIMO-2958-2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.