You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/09 07:03:31 UTC

[GitHub] [rocketmq-mqtt] DongyuanPan opened a new pull request, #136: Delete unused data members, and optimizing abstract interfaces

DongyuanPan opened a new pull request, #136:
URL: https://github.com/apache/rocketmq-mqtt/pull/136

   #135 Delete unused data members, and optimizing abstract interfaces


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #136: Delete unused data members, and optimizing abstract interfaces

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #136:
URL: https://github.com/apache/rocketmq-mqtt/pull/136#issuecomment-1209574614

   # [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/136?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#136](https://codecov.io/gh/apache/rocketmq-mqtt/pull/136?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dee34c9) into [develop](https://codecov.io/gh/apache/rocketmq-mqtt/commit/c8f6b555d2ff87b79796e08652b2efd2469f7fa9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8f6b55) will **increase** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #136      +/-   ##
   ===========================================
   + Coverage    41.95%   41.97%   +0.01%     
   ===========================================
     Files          118      118              
     Lines         4900     4898       -2     
     Branches       713      713              
   ===========================================
     Hits          2056     2056              
   + Misses        2490     2488       -2     
     Partials       354      354              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/rocketmq/mqtt/meta/raft/MqttStateMachine.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9tZXRhL3JhZnQvTXF0dFN0YXRlTWFjaGluZS5qYXZh) | `0.00% <ø> (ø)` | |
   | [...qtt/meta/raft/processor/CounterStateProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9tZXRhL3JhZnQvcHJvY2Vzc29yL0NvdW50ZXJTdGF0ZVByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ketmq/mqtt/meta/raft/processor/StateProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9tZXRhL3JhZnQvcHJvY2Vzc29yL1N0YXRlUHJvY2Vzc29yLmphdmE=) | `0.00% <ø> (ø)` | |
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-mqtt] pingww merged pull request #136: Delete unused data members, and optimizing abstract interfaces

Posted by GitBox <gi...@apache.org>.
pingww merged PR #136:
URL: https://github.com/apache/rocketmq-mqtt/pull/136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org