You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "sungwy (via GitHub)" <gi...@apache.org> on 2026/07/15 19:52:34 UTC
[PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
sungwy opened a new pull request, #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73
There's two issues with the current LICENSE & NOTICE files:
- NOTICE does not contain the [full standard ASF attribution required by the ASF legal policy](https://www.apache.org/legal/src-headers.html#notice)
- We do not have a separate LICENSE and NOTICE that list the license and notices for the packaged binary code (see below)
### Binary LICENSE & NOTICE
Our release process publishes 8 binaries, and in these binaries, we have modules that are statically linked that must be accounted for in the LICENSE and NOTICE files.
References:
- https://www.apache.org/legal/release-policy.html#distribute-other-artifacts
- https://www.apache.org/legal/release-policy.html#licensing-documentation
- https://www.apache.org/legal/release-policy.html#license-file
This PR follows [apache/spark](https://github.com/apache/spark)'s model of listing out the license texts in a separate directory to keep the packaged `LICENSE` minimal, given that we have more than 50 licenses to list already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on PR #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73#issuecomment-4985673332
spark-kubernetes-operator excludes Apache Spark's NOTICE:
https://github.com/apache/spark-kubernetes-operator/blob/main/NOTICE-binary
I'll refrain from adding propagating the NOTICE from `iceberg-go` for now since it's under the same copyright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on PR #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73#issuecomment-4985650403
Thanks for the review @RussellSpitzer
> I looked manually and it seemed fine. Bot told me that we're missing arrow-go + thrift. I'm seeing a partial license for arrow-go. Do we need thrift since it's a transitive dependency?
That's a good point @rambleraptor - I intentionally left it out initially because I thought we didn't need to include other Apache Software Foundation projects into the NOTICE file. But this document seems to leave this a bit ambiguous:
https://infra.apache.org/licensing-howto.html#bundle-asf-product
```
Bundling other ASF products
It is not necessary to duplicate the line "This product includes software developed at the Apache Software Foundation...", though the ASF copyright line and any other portions of NOTICE must be considered for propagation.
```
There's precedent in apache/spark and apache/iceberg/kafka-connect-runtime for including other ASF projects into the NOTICE file. So I think it would make sense to include these (and iceberg-go) too.
Spark: https://github.com/apache/spark/blob/e9121bbf5a94b724b195a6f11c35a1a2d562e3d5/NOTICE-binary#L60-L64
kafka-connect-runtime: https://github.com/apache/iceberg/blob/98e9e43de56a9378a8e6434cc160bc3faeeab9be/kafka-connect/kafka-connect-runtime/main/NOTICE#L105-L107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
Posted by "sungwy (via GitHub)" <gi...@apache.org>.
sungwy commented on code in PR #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73#discussion_r3591389098
##########
licenses-binary/LICENSE-gopkg.in-yaml.v3.txt:
##########
@@ -0,0 +1,50 @@
+
+This project is covered by two different licenses: MIT and Apache.
+
+#### MIT License ####
+
+The following files were ported to Go from C files of libyaml, and thus
+are still covered by their original MIT license, with the additional
+copyright staring in 2011 when the project was ported over:
+
Review Comment:
this is a typo that exists in the source LICENSE file. safe to ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73#issuecomment-4985370487
We might need to add a notice for Apache Thrift.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73#discussion_r3591120658
##########
licenses-binary/LICENSE-gopkg.in-yaml.v3.txt:
##########
@@ -0,0 +1,50 @@
+
+This project is covered by two different licenses: MIT and Apache.
+
+#### MIT License ####
+
+The following files were ported to Go from C files of libyaml, and thus
+are still covered by their original MIT license, with the additional
+copyright staring in 2011 when the project was ported over:
+
Review Comment:
Typo in the license text: "copyright staring" should be "copyright starting".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: add license and notice for binary distribution [terraform-provider-iceberg]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #73:
URL: https://github.com/apache/terraform-provider-iceberg/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org