[GitHub] [doris] platoneko commented on a diff in pull request #17252: [fix](cooldown) Fix deadlock in tablet clone

["platoneko (via GitHub)" <gi...@apache.org>]

platoneko commented on code in PR #17252:
URL: https://github.com/apache/doris/pull/17252#discussion_r1121271787


##########
be/src/olap/tablet.cpp:
##########
@@ -1642,7 +1642,7 @@ void Tablet::_init_context_common_fields(RowsetWriterContext& context) {
 }
 
 Status Tablet::create_rowset(const RowsetMetaSharedPtr& rowset_meta, RowsetSharedPtr* rowset) {
-    return RowsetFactory::create_rowset(tablet_schema(), tablet_path(), rowset_meta, rowset);
+    return RowsetFactory::create_rowset(_schema, tablet_path(), rowset_meta, rowset);

Review Comment:
   If `rowset_meta` has schema, new rowset will use tablet_schema in `rowset_meta`(after version 1.2), otherwise it MUST be old version before 1.2 which doesn't support light schema change and tablet only has one schema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org