You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@cn.ibm.com> on 2016/04/03 10:30:50 UTC
Review Request 45623: Renamed the parameter 'override' to '_override'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45623/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
Renamed the parameter 'override' to '_override'.
Diffs
-----
src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526
Diff: https://reviews.apache.org/r/45623/diff/
Testing
-------
make check
Thanks,
Qian Zhang
Re: Review Request 45623: Renamed the parameter 'override' to
'_override'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45623/#review126809
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45623]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 3, 2016, 8:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45623/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 8:30 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed the parameter 'override' to '_override'.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526
>
> Diff: https://reviews.apache.org/r/45623/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 45623: Renamed the parameter 'override' to
'_override'.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45623/#review126802
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On April 3, 2016, 8:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45623/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 8:30 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed the parameter 'override' to '_override'.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526
>
> Diff: https://reviews.apache.org/r/45623/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 45623: Renamed the parameter 'override' to
'_override'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45623/#review127387
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 3, 2016, 8:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45623/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 8:30 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed the parameter 'override' to '_override'.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 76773914adb021dda2324eb566db0c697a353526
>
> Diff: https://reviews.apache.org/r/45623/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>