You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/05 14:09:25 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #2839:
[Compaction] Avoid unnecessary compaction
morningman opened a new pull request #2839: [Compaction] Avoid unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839
It is not necessary to perform compaction in the following cases
1. A tablet has only 2 rowsets, the versions are [0-1] and [2-x]. In this case,
there is no need to perform base compaction because the [0-1] version is an empty version.
2. The initial value of the `last successful execution time of compaction` is 0,
which causes the first time to determine the time interval from the
last successful execution time of compaction, which always meets the
conditions to trigger cumulative compaction.
ISSUE: #2838
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2839: [Compaction]
Avoid unnecessary compaction
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2839: [Compaction] Avoid unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#2839: [Compaction] Avoid unnecessary compaction
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375626880
##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::pick_rowsets_to_compact() {
}
double base_cumulative_delta_ratio = config::base_cumulative_delta_ratio;
+ if (base_size == 0) {
Review comment:
`_input_rowsets.size()` is the number of rowsets.
For example, we have 2 rowsets with version: [0-1] and [2-2];
the `base_size` here is the data size of [0-1], which can be zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#2839: [Compaction] Avoid unnecessary compaction
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375349589
##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::pick_rowsets_to_compact() {
}
double base_cumulative_delta_ratio = config::base_cumulative_delta_ratio;
+ if (base_size == 0) {
Review comment:
We have checked `input_rowsets.size ` firstly, so _input_rowsets.size() at least should be 2 and the base_size should larger than zero.
```
if (_input_rowsets.size() <= 1) {
return OLAP_ERR_BE_NO_SUITABLE_VERSION;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#2839: [Compaction] Avoid unnecessary compaction
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375642809
##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::pick_rowsets_to_compact() {
}
double base_cumulative_delta_ratio = config::base_cumulative_delta_ratio;
+ if (base_size == 0) {
Review comment:
OK. I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org