You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/09 00:02:25 UTC

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11974: [Issue 11846][Java client] Create a consumer in the paused state

Anonymitaet commented on a change in pull request #11974:
URL: https://github.com/apache/pulsar/pull/11974#discussion_r704854674



##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
##########
@@ -741,4 +741,12 @@
      * corruption, deserialization error, etc.).
      */
     ConsumerBuilder<T> poolMessages(boolean poolMessages);
+
+    /**
+     * Start the consumer in a paused state. When enabled, the consumer will not immediately fetch messages when

Review comment:
       ```suggestion
        * Start the consumer in a paused state. When enabled, the consumer does not immediately fetch messages when
   ```

##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
##########
@@ -741,4 +741,12 @@
      * corruption, deserialization error, etc.).
      */
     ConsumerBuilder<T> poolMessages(boolean poolMessages);
+
+    /**
+     * Start the consumer in a paused state. When enabled, the consumer will not immediately fetch messages when
+     * {@link #subscribe()} is called. Instead, the consumer will wait to fetch messages until {@link Consumer#resume()} is called.

Review comment:
       ```suggestion
        * {@link #subscribe()} is called. Instead, the consumer waits to fetch messages until {@link Consumer#resume()} is called.
   ```

##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
##########
@@ -741,4 +741,12 @@
      * corruption, deserialization error, etc.).
      */
     ConsumerBuilder<T> poolMessages(boolean poolMessages);
+
+    /**
+     * Start the consumer in a paused state. When enabled, the consumer will not immediately fetch messages when

Review comment:
       Use present tense in tech writing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org