[GitHub] [cassandra-sidecar] frankgh commented on a diff in pull request #47: CASSANDRASC-52 Sidecar Returns Own Version in Node Settings

["frankgh (via GitHub)" <gi...@apache.org>]

frankgh commented on code in PR #47:
URL: https://github.com/apache/cassandra-sidecar/pull/47#discussion_r1212433266


##########
common/build.gradle:
##########
@@ -23,6 +23,7 @@ test {
 }
 
 dependencies {
+    implementation(group: 'commons-io', name: 'commons-io', version: '2.12.0')

Review Comment:
   common should have a minimal amount of dependencies. Let's not add this dependency just for reading the input stream



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org